[PR #30] [MERGED] Single activity approach #37

New Issue

adam · 2025-12-30T01:29:45+01:00

adam commented

2025-12-30 01:29:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/30
Author: @melihaksoy
Created: 8/16/2019
Status: ✅ Merged
Merged: 8/21/2019
Merged by: @melihaksoy

Base: master ← Head: single-activity

📝 Commits (9)

edc2a68 Created single activity, removed other activities, created graph for navigation
1b913f5 WIP for single activity, graph & navigation done
cbc87b0 Fixing detekt findings
5ee641a Removed base activity since its no longer needed
fbe8e41 Bundle settings
4499755 CircleCI config fixes
6a90aa1 Test mem options added for CI builds
8ebfaa5 Implicit deeplinking via navController navigate
47bebcf Removed jacoco.exec files. Closes # 32

📊 Changes

36 files changed (+402 additions, -322 deletions)

View changed files

📝 .circleci/config.yml (+54 -7)
📝 .gitignore (+5 -0)
➕ Gemfile.lock (+159 -0)
📝 app/build.gradle (+3 -0)
📝 app/src/main/AndroidManifest.xml (+13 -2)
➕ app/src/main/kotlin/com/melih/rocketscience/MainActivity.kt (+31 -0)
📝 app/src/main/kotlin/com/melih/rocketscience/di/AppComponent.kt (+1 -4)
➕ app/src/main/kotlin/com/melih/rocketscience/di/AppModule.kt (+19 -0)
📝 app/src/main/res/layout/activity_main.xml (+10 -5)
➕ app/src/main/res/navigation/nav_main.xml (+10 -0)
📝 build.gradle (+1 -1)
➖ core/jacoco.exec (+0 -0)
📝 core/src/main/AndroidManifest.xml (+4 -3)
📝 core/src/main/kotlin/com/melih/core/actions/Actions.kt (+6 -10)
➖ core/src/main/kotlin/com/melih/core/base/lifecycle/BaseActivity.kt (+0 -56)
📝 core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt (+2 -5)
📝 core/src/main/res/values/strings.xml (+9 -12)
📝 fastlane/Fastfile (+41 -5)
📝 features/detail/build.gradle (+0 -1)
➖ features/detail/jacoco.exec (+0 -0)

...and 16 more files

📄 Description

Things that needs implementation:

Receiver intent filtering
Dependenct module for MainActivity & injection for NavigationReceiver
NavigationReceiver intent action checks etc.

Will also work on using custom navArgs and navDirections since now they're created in app module rather then their corresponding module - but this might be another PR.

Current approach should be saved in another branch and kept as an example before this is merged.

This will close #28.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/30 **Author:** [@melihaksoy](https://github.com/melihaksoy) **Created:** 8/16/2019 **Status:** ✅ Merged **Merged:** 8/21/2019 **Merged by:** [@melihaksoy](https://github.com/melihaksoy) **Base:** `master` ← **Head:** `single-activity` --- ### 📝 Commits (9) - [`edc2a68`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/edc2a688106172aee62e71341b8ac6ebeb51a7e7) Created single activity, removed other activities, created graph for navigation - [`1b913f5`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/1b913f55b9fc501aa8eadd8c11fb6d8a13a7a1d2) WIP for single activity, graph & navigation done - [`cbc87b0`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/cbc87b01b3793ed3ecb6ac5630b6da09c6a8223a) Fixing detekt findings - [`5ee641a`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/5ee641a55eec807559048b7d261cd9c9e3da718e) Removed base activity since its no longer needed - [`fbe8e41`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/fbe8e413ea58af7af1dd77ae63aa0d121fe552e5) Bundle settings - [`4499755`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/4499755196d6f6a9bd8799d9ca47eaea24c934c4) CircleCI config fixes - [`6a90aa1`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/6a90aa13d0c554cfa7136a187d7955925cf796c7) Test mem options added for CI builds - [`8ebfaa5`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/8ebfaa5baf6a470bb8e1a144321238d112096ca1) Implicit deeplinking via navController navigate - [`47bebcf`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/47bebcf5669d0129610d42ccbbbdc4c8112e9967) Removed jacoco.exec files. Closes # 32 ### 📊 Changes **36 files changed** (+402 additions, -322 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.yml` (+54 -7) 📝 `.gitignore` (+5 -0) ➕ `Gemfile.lock` (+159 -0) 📝 `app/build.gradle` (+3 -0) 📝 `app/src/main/AndroidManifest.xml` (+13 -2) ➕ `app/src/main/kotlin/com/melih/rocketscience/MainActivity.kt` (+31 -0) 📝 `app/src/main/kotlin/com/melih/rocketscience/di/AppComponent.kt` (+1 -4) ➕ `app/src/main/kotlin/com/melih/rocketscience/di/AppModule.kt` (+19 -0) 📝 `app/src/main/res/layout/activity_main.xml` (+10 -5) ➕ `app/src/main/res/navigation/nav_main.xml` (+10 -0) 📝 `build.gradle` (+1 -1) ➖ `core/jacoco.exec` (+0 -0) 📝 `core/src/main/AndroidManifest.xml` (+4 -3) 📝 `core/src/main/kotlin/com/melih/core/actions/Actions.kt` (+6 -10) ➖ `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseActivity.kt` (+0 -56) 📝 `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt` (+2 -5) 📝 `core/src/main/res/values/strings.xml` (+9 -12) 📝 `fastlane/Fastfile` (+41 -5) 📝 `features/detail/build.gradle` (+0 -1) ➖ `features/detail/jacoco.exec` (+0 -0) _...and 16 more files_ </details> ### 📄 Description Things that needs implementation: - Receiver intent filtering - Dependenct module for `MainActivity` & injection for `NavigationReceiver` - `NavigationReceiver` intent action checks etc. Will also work on using custom `navArgs` and `navDirections` since now they're created in `app` module rather then their corresponding module - but this might be another PR. Current approach should be saved in another branch and kept as an example before this is merged. This will close #28. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:29:45 +01:00

adam closed this issue

2025-12-30 01:29:45 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Android-Kotlin-Modulerized-CleanArchitecture#37