starred/Android-Kotlin-Modulerized-CleanArchitecture
1
0
Fork 0
mirror of https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture.git synced 2026-03-22 17:39:58 +01:00
Code Issues 8 Packages Projects Releases Wiki Activity

List lefover fixes

Browse Source
This commit is contained in:
Melih Aksoy
2019-07-26 16:37:03 +02:00
parent cd7f55046d
commit 23d9ae6a62
3 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/src/main/kotlin/com/melih/core/base/recycler/BasePagingListAdapter.kt
View File

@@ -9,16 +9,12 @@ import androidx.recyclerview.widget.RecyclerView
/** /**
* Base adapter to reduce boilerplate on creating / binding view holders. * Base adapter to reduce boilerplate on creating / binding view holders.
*
*
*/ */
abstract class BasePagingListAdapter<T>( abstract class BasePagingListAdapter<T>(
callback: DiffUtil.ItemCallback<T>, callback: DiffUtil.ItemCallback<T>,
private val clickListener: (T?) -> Unit private val clickListener: (T) -> Unit
) : PagedListAdapter<T, BaseViewHolder<T>>(callback) { ) : PagedListAdapter<T, BaseViewHolder<T>>(callback) {
private var itemClickListener: ((T) -> Unit)? = null
/** /**
* This method will be called to create view holder to obfuscate layout inflation creation / process * This method will be called to create view holder to obfuscate layout inflation creation / process
* *
@@ -46,14 +42,14 @@ abstract class BasePagingListAdapter<T>(
* Calls [bind][BaseViewHolder.bind] on view holders * Calls [bind][BaseViewHolder.bind] on view holders
*/ */
override fun onBindViewHolder(holder: BaseViewHolder<T>, position: Int) { override fun onBindViewHolder(holder: BaseViewHolder<T>, position: Int) {
val item = getItem(position) getItem(position)?.also { item ->
holder.itemView.setOnClickListener { view ->
clickListener(item)
}
holder.itemView.setOnClickListener { holder.bind(item)
clickListener(item)
} }
holder.bind(item)
} }
} }
@@ -68,5 +64,5 @@ abstract class BaseViewHolder<T>(binding: ViewDataBinding) : RecyclerView.ViewHo
* @param item entity * @param item entity
* @param position position from adapter * @param position position from adapter
*/ */
abstract fun bind(item: T?) abstract fun bind(item: T)
} }

4
features/launches/src/main/kotlin/com/melih/list/ui/LaunchesFragment.kt
View File

@@ -70,8 +70,8 @@ class LaunchesFragment : BaseDaggerFragment<ListBinding>(), SwipeRefreshLayout.O
//} //}
} }
private fun onItemSelected(item: LaunchEntity?) { private fun onItemSelected(item: LaunchEntity) {
startActivity(Actions.openDetailFor(item?.id ?: -1L)) startActivity(Actions.openDetailFor(item.id))
} }
//private fun onSearchExpand() { //private fun onSearchExpand() {

6
features/launches/src/main/kotlin/com/melih/list/ui/adapters/LaunchesAdapter.kt
View File

@@ -8,7 +8,7 @@ import com.melih.core.base.recycler.BaseViewHolder
import com.melih.list.databinding.LaunchRowBinding import com.melih.list.databinding.LaunchRowBinding
import com.melih.repository.entities.LaunchEntity import com.melih.repository.entities.LaunchEntity
class LaunchesAdapter(itemClickListener: (LaunchEntity?) -> Unit) : BasePagingListAdapter<LaunchEntity>( class LaunchesAdapter(itemClickListener: (LaunchEntity) -> Unit) : BasePagingListAdapter<LaunchEntity>(
object : DiffUtil.ItemCallback<LaunchEntity>() { object : DiffUtil.ItemCallback<LaunchEntity>() {
override fun areItemsTheSame(oldItem: LaunchEntity, newItem: LaunchEntity): Boolean = override fun areItemsTheSame(oldItem: LaunchEntity, newItem: LaunchEntity): Boolean =
oldItem.id == newItem.id oldItem.id == newItem.id
@@ -30,10 +30,10 @@ class LaunchesAdapter(itemClickListener: (LaunchEntity?) -> Unit) : BasePagingLi
class LaunchesViewHolder(private val binding: LaunchRowBinding) : BaseViewHolder<LaunchEntity>(binding) { class LaunchesViewHolder(private val binding: LaunchRowBinding) : BaseViewHolder<LaunchEntity>(binding) {
override fun bind(item: LaunchEntity?) { override fun bind(item: LaunchEntity) {
binding.entity = item binding.entity = item
val missions = item?.missions val missions = item.missions
binding.tvDescription.text = if (!missions.isNullOrEmpty()) missions[0].description else "" binding.tvDescription.text = if (!missions.isNullOrEmpty()) missions[0].description else ""
binding.executePendingBindings() binding.executePendingBindings()