github-mirrors/terraform-provider-bitbucketserver
1
0
Fork 0
mirror of https://github.com/ysoftdevs/terraform-provider-bitbucketserver.git synced 2026-04-24 01:28:29 +02:00
Code Issues Packages Projects Releases 1 Wiki Activity

Fix zero required approvals being ignored

Browse Source
This commit is contained in:
Martin Litvaj
2020-07-21 19:16:35 +02:00
parent f7ff5040fa
commit f11b275f56
2 changed files with 42 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
bitbucket/resource_default_reviewers_condition_test.go
View File

@@ -35,6 +35,30 @@ func TestAccBitbucketDefaultReviewersCondition_forProject(t *testing.T) {
})
}
func TestAccBitbucketDefaultReviewersCondition_noRequiredApprovals(t *testing.T) {
key := fmt.Sprintf("%v", rand.New(rand.NewSource(time.Now().UnixNano())).Int())
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckBitbucketDefaultReviewersConditionDestroy,
Steps: []resource.TestStep{
{
Config: testAccBitbucketDefaultReviewersConditionResourceForProject(key, 0),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "project_key", "TEST"+key),
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "source_matcher.id", "any"),
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "source_matcher.type_id", "ANY_REF"),
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "target_matcher.id", "any"),
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "target_matcher.type_id", "ANY_REF"),
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "reviewers.#", "1"),
resource.TestCheckResourceAttr("bitbucketserver_default_reviewers_condition.test", "required_approvals", "0"),
),
},
},
})
}
func TestAccBitbucketDefaultReviewersCondition_forRepository(t *testing.T) {
key := fmt.Sprintf("%v", rand.New(rand.NewSource(time.Now().UnixNano())).Int())