Merge pull request #20 from Kamahl19/fix-missing-resource

Fix missing Default reviewers condition resource
This commit is contained in:
Gavin Bunney
2020-09-18 08:54:00 -07:00
committed by GitHub

View File

@@ -321,10 +321,7 @@ func resourceDefaultReviewersConditionRead(d *schema.ResourceData, m interface{}
return err return err
} }
if resp.StatusCode != 200 { if resp.StatusCode == 200 {
return fmt.Errorf("unable to find a matching default reviewers condition %s. API returned %d", d.Id(), resp.StatusCode)
}
var conditions []DefaultReviewersConditionResp var conditions []DefaultReviewersConditionResp
body, err := ioutil.ReadAll(resp.Body) body, err := ioutil.ReadAll(resp.Body)
@@ -349,12 +346,11 @@ func resourceDefaultReviewersConditionRead(d *schema.ResourceData, m interface{}
d.Set("target_matcher", collapseMatcher(refMatcherToMatcher(c.TargetRefMatcher))) d.Set("target_matcher", collapseMatcher(refMatcherToMatcher(c.TargetRefMatcher)))
d.Set("reviewers", collapseReviewers(c.Reviewers)) d.Set("reviewers", collapseReviewers(c.Reviewers))
d.Set("required_approvals", c.RequiredApprovals) d.Set("required_approvals", c.RequiredApprovals)
}
}
}
return nil return nil
}
}
return fmt.Errorf("unable to find a matching default reviewers condition %s", d.Id())
} }
func resourceDefaultReviewersConditionDelete(d *schema.ResourceData, m interface{}) error { func resourceDefaultReviewersConditionDelete(d *schema.ResourceData, m interface{}) error {