mirror of
https://github.com/ysoftdevs/terraform-aws-eks.git
synced 2026-04-25 10:08:25 +02:00
Merge pull request #2 from terraform-aws-modules/fix/git_hooks_and_ci
fixing up CI and git hooks
This commit is contained in:
10
.github/PULL_REQUEST_TEMPLATE.md
vendored
10
.github/PULL_REQUEST_TEMPLATE.md
vendored
@@ -6,8 +6,8 @@ Please explain the changes you made here and link to any relevant issues.
|
||||
|
||||
### Checklist
|
||||
|
||||
* [ ] `terraform fmt` and `terraform validate` both work from the root and `examples/alb_test_fixture` directories (look in CI for an example)
|
||||
* [ ] Tests for the changes have been added and passing (for bug fixes/features)
|
||||
* [ ] Test results are pasted in this PR (in lieu of CI)
|
||||
* [ ] Docs have been added/updated (for bug fixes/features)
|
||||
* [ ] Any breaking changes are noted in the description above
|
||||
- [ ] `terraform fmt` and `terraform validate` both work from the root and `examples/eks_test_fixture` directories (look in CI for an example)
|
||||
- [ ] Tests for the changes have been added and passing (for bug fixes/features)
|
||||
- [ ] Test results are pasted in this PR (in lieu of CI)
|
||||
- [ ] Docs have been added/updated (for bug fixes/features)
|
||||
- [ ] Any breaking changes are noted in the description above
|
||||
|
||||
@@ -3,13 +3,11 @@
|
||||
repos:
|
||||
- repo: git://github.com/antonbabenko/pre-commit-terraform
|
||||
rev: v1.7.1
|
||||
sha: 091f8b15d7b458e5a0aca642483deb2205e7db02
|
||||
hooks:
|
||||
- id: terraform_fmt
|
||||
# - id: terraform_docs
|
||||
- repo: git://github.com/pre-commit/pre-commit-hooks
|
||||
rev: v1.2.3
|
||||
sha: 92e1570c282e3c69a1f8b5b8dd8d286fe27cfaa7
|
||||
hooks:
|
||||
- id: check-merge-conflict
|
||||
- id: trailing-whitespace
|
||||
|
||||
@@ -26,7 +26,7 @@ script:
|
||||
- echo 'script'
|
||||
- terraform init
|
||||
- terraform fmt -check=true
|
||||
- terraform validate -var "region=${AWS_REGION}" -var "vpc_id=vpc-123456" -var "subnets=['subnet-12345a']" -var "workers_ami_id=ami-123456" -var "cluster_ingress_cidrs=[]" -var "cluster_name=test_cluster"
|
||||
- terraform validate -var "region=${AWS_REGION}" -var "vpc_id=vpc-123456" -var "subnets=[\"subnet-12345a\"]" -var "workers_ami_id=ami-123456" -var "cluster_ingress_cidrs=[]" -var "cluster_name=test_cluster"
|
||||
- docker run --rm -v $(pwd):/app/ --workdir=/app/ -t wata727/tflint --error-with-issues
|
||||
- cd examples/eks_test_fixture
|
||||
- terraform init
|
||||
|
||||
Reference in New Issue
Block a user