From d990ea8aff682315828d7c177a309c71541e023c Mon Sep 17 00:00:00 2001 From: Bryant Biggs Date: Fri, 22 Jul 2022 08:29:00 -0400 Subject: [PATCH] fix: Pin TLS provider version to 3.x versions only (#2174) --- .pre-commit-config.yaml | 2 +- README.md | 4 ++-- examples/eks_managed_node_group/README.md | 4 ++-- examples/eks_managed_node_group/versions.tf | 2 +- examples/self_managed_node_group/README.md | 4 ++-- examples/self_managed_node_group/versions.tf | 2 +- main.tf | 2 +- versions.tf | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9eaabc7..727e21c 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/antonbabenko/pre-commit-terraform - rev: v1.73.0 + rev: v1.74.1 hooks: - id: terraform_fmt - id: terraform_validate diff --git a/README.md b/README.md index 50eb79e..9a80aa5 100644 --- a/README.md +++ b/README.md @@ -210,7 +210,7 @@ We are grateful to the community for contributing bugfixes and improvements! Ple | [terraform](#requirement\_terraform) | >= 0.13.1 | | [aws](#requirement\_aws) | >= 3.72 | | [kubernetes](#requirement\_kubernetes) | >= 2.10 | -| [tls](#requirement\_tls) | >= 3.0 | +| [tls](#requirement\_tls) | ~> 3.0 | ## Providers @@ -218,7 +218,7 @@ We are grateful to the community for contributing bugfixes and improvements! Ple |------|---------| | [aws](#provider\_aws) | >= 3.72 | | [kubernetes](#provider\_kubernetes) | >= 2.10 | -| [tls](#provider\_tls) | >= 3.0 | +| [tls](#provider\_tls) | ~> 3.0 | ## Modules diff --git a/examples/eks_managed_node_group/README.md b/examples/eks_managed_node_group/README.md index 33016c0..ea51a15 100644 --- a/examples/eks_managed_node_group/README.md +++ b/examples/eks_managed_node_group/README.md @@ -60,14 +60,14 @@ Note that this example may create resources which cost money. Run `terraform des | [terraform](#requirement\_terraform) | >= 0.13.1 | | [aws](#requirement\_aws) | >= 3.72 | | [kubernetes](#requirement\_kubernetes) | >= 2.10 | -| [tls](#requirement\_tls) | >= 2.2 | +| [tls](#requirement\_tls) | ~> 3.0 | ## Providers | Name | Version | |------|---------| | [aws](#provider\_aws) | >= 3.72 | -| [tls](#provider\_tls) | >= 2.2 | +| [tls](#provider\_tls) | ~> 3.0 | ## Modules diff --git a/examples/eks_managed_node_group/versions.tf b/examples/eks_managed_node_group/versions.tf index 40b7e32..7fa16dc 100644 --- a/examples/eks_managed_node_group/versions.tf +++ b/examples/eks_managed_node_group/versions.tf @@ -8,7 +8,7 @@ terraform { } tls = { source = "hashicorp/tls" - version = ">= 2.2" + version = "~> 3.0" } kubernetes = { source = "hashicorp/kubernetes" diff --git a/examples/self_managed_node_group/README.md b/examples/self_managed_node_group/README.md index a0caf4a..cfdff57 100644 --- a/examples/self_managed_node_group/README.md +++ b/examples/self_managed_node_group/README.md @@ -28,14 +28,14 @@ Note that this example may create resources which cost money. Run `terraform des | [terraform](#requirement\_terraform) | >= 0.13.1 | | [aws](#requirement\_aws) | >= 3.72 | | [kubernetes](#requirement\_kubernetes) | >= 2.10 | -| [tls](#requirement\_tls) | >= 2.2 | +| [tls](#requirement\_tls) | ~> 3.0 | ## Providers | Name | Version | |------|---------| | [aws](#provider\_aws) | >= 3.72 | -| [tls](#provider\_tls) | >= 2.2 | +| [tls](#provider\_tls) | ~> 3.0 | ## Modules diff --git a/examples/self_managed_node_group/versions.tf b/examples/self_managed_node_group/versions.tf index 40b7e32..7fa16dc 100644 --- a/examples/self_managed_node_group/versions.tf +++ b/examples/self_managed_node_group/versions.tf @@ -8,7 +8,7 @@ terraform { } tls = { source = "hashicorp/tls" - version = ">= 2.2" + version = "~> 3.0" } kubernetes = { source = "hashicorp/kubernetes" diff --git a/main.tf b/main.tf index 82f3f7a..593ab77 100644 --- a/main.tf +++ b/main.tf @@ -91,7 +91,7 @@ module "kms" { source = "terraform-aws-modules/kms/aws" version = "1.0.2" # Note - be mindful of Terraform/provider version compatibility between modules - create = var.create_kms_key + create = local.create && var.create_kms_key description = coalesce(var.kms_key_description, "${var.cluster_name} cluster encryption key") key_usage = "ENCRYPT_DECRYPT" diff --git a/versions.tf b/versions.tf index fde7af0..7fa16dc 100644 --- a/versions.tf +++ b/versions.tf @@ -8,7 +8,7 @@ terraform { } tls = { source = "hashicorp/tls" - version = ">= 3.0" + version = "~> 3.0" } kubernetes = { source = "hashicorp/kubernetes"