feat!: Add support for Outposts, remove node security group, add support for addon preserve and most_recent configurations (#2250)

Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Resolves undefined

modules/eks-managed-node-group/variables.tf

@@ -84,12 +84,24 @@ variable "create_launch_template" {
   default     = true
 }
 
-variable "launch_template_name" {
-  description = "Launch template name - either to be created (`var.create_launch_template` = `true`) or existing (`var.create_launch_template` = `false`)"
+variable "use_custom_launch_template" {
+  description = "Determines whether to use a custom launch template or not. If set to `false`, EKS will use its own default launch template"
+  type        = bool
+  default     = true
+}
+
+variable "launch_template_id" {
+  description = "The ID of an existing launch template to use. Required when `create_launch_template` = `false` and `use_custom_launch_template` = `true`"
   type        = string
   default     = ""
 }
 
+variable "launch_template_name" {
+  description = "Name of launch template to be created"
+  type        = string
+  default     = null
+}
+
 variable "launch_template_use_name_prefix" {
   description = "Determines whether to use `launch_template_name` as is or create a unique name beginning with the `launch_template_name` as the prefix"
   type        = bool
@@ -188,7 +200,7 @@ variable "credit_specification" {
 
 variable "elastic_gpu_specifications" {
   description = "The elastic GPU to attach to the instance"
-  type        = map(string)
+  type        = any
   default     = {}
 }
 
@@ -210,9 +222,15 @@ variable "instance_market_options" {
   default     = {}
 }
 
+variable "maintenance_options" {
+  description = "The maintenance options for the instance"
+  type        = any
+  default     = {}
+}
+
 variable "license_specifications" {
-  description = "A list of license specifications to associate with"
-  type        = map(string)
+  description = "A map of license specifications to associate with"
+  type        = any
   default     = {}
 }
 
@@ -244,6 +262,12 @@ variable "placement" {
   default     = {}
 }
 
+variable "private_dns_name_options" {
+  description = "The options for the instance hostname. The default values are inherited from the subnet"
+  type        = map(string)
+  default     = {}
+}
+
 variable "launch_template_tags" {
   description = "A map of additional tags to add to the tag_specifications of launch template created"
   type        = map(string)
@@ -309,7 +333,7 @@ variable "capacity_type" {
 }
 
 variable "disk_size" {
-  description = "Disk size in GiB for nodes. Defaults to `20`"
+  description = "Disk size in GiB for nodes. Defaults to `20`. Only valid when `use_custom_launch_template` = `false`"
   type        = number
   default     = null
 }
@@ -345,7 +369,7 @@ variable "launch_template_version" {
 }
 
 variable "remote_access" {
-  description = "Configuration block with remote access settings"
+  description = "Configuration block with remote access settings. Only valid when `use_custom_launch_template` = `false`"
   type        = any
   default     = {}
 }
@@ -359,7 +383,9 @@ variable "taints" {
 variable "update_config" {
   description = "Configuration block of settings for max unavailable resources during node group updates"
   type        = map(string)
-  default     = {}
+  default = {
+    max_unavailable_percentage = 33
+  }
 }
 
 variable "timeouts" {
@@ -368,58 +394,6 @@ variable "timeouts" {
   default     = {}
 }
 
-################################################################################
-# Security Group
-################################################################################
-
-variable "create_security_group" {
-  description = "Determines whether to create a security group"
-  type        = bool
-  default     = true
-}
-
-variable "security_group_name" {
-  description = "Name to use on security group created"
-  type        = string
-  default     = null
-}
-
-variable "security_group_use_name_prefix" {
-  description = "Determines whether the security group name (`security_group_name`) is used as a prefix"
-  type        = bool
-  default     = true
-}
-
-variable "security_group_description" {
-  description = "Description for the security group created"
-  type        = string
-  default     = "EKS managed node group security group"
-}
-
-variable "vpc_id" {
-  description = "ID of the VPC where the security group/nodes will be provisioned"
-  type        = string
-  default     = null
-}
-
-variable "security_group_rules" {
-  description = "List of security group rules to add to the security group created"
-  type        = any
-  default     = {}
-}
-
-variable "cluster_security_group_id" {
-  description = "Cluster control plane security group ID"
-  type        = string
-  default     = null
-}
-
-variable "security_group_tags" {
-  description = "A map of additional tags to add to the security group created"
-  type        = map(string)
-  default     = {}
-}
-
 ################################################################################
 # IAM Role
 ################################################################################
@@ -480,8 +454,8 @@ variable "iam_role_attach_cni_policy" {
 
 variable "iam_role_additional_policies" {
   description = "Additional policies to be added to the IAM role"
-  type        = list(string)
-  default     = []
+  type        = map(string)
+  default     = {}
 }
 
 variable "iam_role_tags" {