github-mirrors/odc-analyzer
1
0
Fork 0
mirror of https://github.com/ysoftdevs/odc-analyzer.git synced 2026-04-30 12:24:26 +02:00
Code Issues 2 Packages Projects Releases Wiki Activity

Added support for finding log smells using custom regular expressions.

Browse Source
This commit is contained in:
Šesták Vít
2016-12-05 09:29:49 +01:00
parent 0992857e75
commit b4e7bd251e
3 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/controllers/DependencyCheckReportsProcessor.scala
View File

@@ -6,11 +6,12 @@ import com.google.inject.name.Named
import com.ysoft.odc.Checks._
import com.ysoft.odc._
import com.ysoft.odc.statistics.FailedProjects
import modules.{LogSmell, LogSmellChecks}
import org.joda.time.DateTimeConstants
import play.api.Logger
import play.api.i18n.{I18nSupport, MessagesApi}
import play.api.mvc.RequestHeader
import play.twirl.api.Html
import play.twirl.api.{Html, HtmlFormat}
import views.html.DefaultRequest
import scala.concurrent.{ExecutionContext, Future}
@@ -23,6 +24,7 @@ final class DependencyCheckReportsProcessor @Inject() (
@Named("bamboo-server-url") val server: String,
dependencyCheckReportsParser: DependencyCheckReportsParser,
@Named("missing-GAV-exclusions") missingGAVExclusions: MissingGavExclusions,
@Named("log-smells") logSmells: LogSmellChecks,
val messagesApi: MessagesApi
) extends I18nSupport {
@@ -80,10 +82,15 @@ final class DependencyCheckReportsProcessor @Inject() (
log => log.lines.exists(l => (l.toLowerCase startsWith "error") || (l.toLowerCase contains "[error]")),
ProjectWarningBuilder("results-with-error-messages", views.html.warnings.resultsWithErrorMessages(), WarningSeverity.Error)
)
)
) ++ logSmells.checks.toSeq.map { case (id, s) =>
(
(log: String) => log.lines.exists(l => s.regex.pattern.matcher(l).find),
ProjectWarningBuilder(id, HtmlFormat.escape(s.message), s.severity)
)
}
val logWarnings: Seq[Warning] = logChecks.flatMap{case (logCheck, warningBuilder) =>
val resultsWithErrorMessages = successfulResults.filter{case (k, (_, _, log)) => logCheck(log.dataString)}
if(resultsWithErrorMessages.nonEmpty) Some(warningBuilder.forProjects(new FailedProjects(resultsWithErrorMessages.keys.map(projectsReportInfo.reportIdToReportInfo).toSet), buildLink)) else None
val resultsWithErrorMessages = successfulResults.par.filter{case (k, (_, _, log)) => logCheck(log.dataString)}
if(resultsWithErrorMessages.nonEmpty) Some(warningBuilder.forProjects(new FailedProjects(resultsWithErrorMessages.keys.map(projectsReportInfo.reportIdToReportInfo).seq.toSet), buildLink)) else None
}
val extraWarnings = Seq[Option[Warning]](
if(unknownIdentifierTypes.size > 0) Some(IdentifiedWarning("unknown-identifier-types", views.html.warnings.unknownIdentifierType(unknownIdentifierTypes), WarningSeverity.Info)) else None,