Fix certificate generation script arguments

README.md

@@ -2,6 +2,12 @@
 
 The responsibility of this webhook is to patch all newly created/updated service account and make sure they all contained proper imagepullsecret configuration. 
 
+This repo produces one helm chart available via helm repository https://ysoftdevs.github.io/imagepullsecret-injector. There are also 2 docker images:
+- `marshallmarshall/imagepullsecret-injector` - the image containing the webhook itself
+- `marshallmarshall/webhook-cert-generator` - helper image responsible for (re)generating the certificates
+
+
+
 ## Helm description
 The helm chart consists of 2 parts: the certificate generator and the webhook configuration itself.
 
@@ -21,22 +27,35 @@ The main part is the deployment and the web hook configuration. The flow is as f
 Of note is also a fact that the chart runs a lookup to the connected cluster to fetch the CA bundle for the MutatingWebhook. This means `helm template` won't work.
 
 ## Running locally
-```bash
+1. Create the prerequisite resources:
-kubectl create ns imagepullsecret-injector
+    ```bash
+    kubectl create ns imagepullsecret-injector
 
-kubectl create secret -n imagepullsecret-injector \
+    kubectl create secret -n imagepullsecret-injector \
-    generic my-cool-secret-source \
+        generic acr-dockerconfigjson-source \
-    --from-literal=.dockerconfigjson='<your .dockerconfigjson configuration file>'
+        --type=kubernetes.io/dockerconfigjson \
+        --from-literal=.dockerconfigjson='<your .dockerconfigjson configuration file>'
+    ```
 
-make build-image
+1. Build the images and run the chart
-helm upgrade -i imagepullsecret-injector \
+    ``` bash
-    --create-namespace -n imagepullsecret-injector \
+    make build-image
-    helm/imagepullsecret-injector
+    helm upgrade -i imagepullsecret-injector \
-```
+        -n imagepullsecret-injector \
+        helm/imagepullsecret-injector
+    ```
+    Alternatively, you can use the pre-built, publicly available helm chart and docker images:
+    ```bash
+    helm repo add imagepullsecret-injector https://ysoftdevs.github.io/imagepullsecret-injector
+    helm repo update
+    helm upgrade -i imagepullsecret-injector \
+        -n imagepullsecret-injector \
+        magepullsecret-injector/imagepullsecret-injector
+    ```
 
-To test whether everything works, you can run
+1. To test whether everything works, you can run
-```bash
+    ```bash
-kubectl create ns yolo
+    kubectl create ns yolo
-kubectl get sa -n yolo default -ojsonpath='{.imagePullSecrets}'
+    kubectl get sa -n yolo default -ojsonpath='{.imagePullSecrets}'
-```
+    ```
-The get command should display _some_ non-empty result.
+    The `get` command should display _some_ non-empty result.

VERSION

@@ -1 +1 @@
-v0.0.8
+0.0.9

helm/imagepullsecret-injector/Chart.yaml

@@ -15,9 +15,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.0.6
+version: 0.0.10
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: v0.0.8
+appVersion: 0.0.9

helm/imagepullsecret-injector/templates/certificate-gen/cronjob-certificate-gen.yaml

@@ -21,9 +21,9 @@ spec:
               image: "{{ .Values.certificateGeneratorImage.registry }}/{{ .Values.certificateGeneratorImage.repository }}:{{ .Values.certificateGeneratorImage.tag | default .Chart.AppVersion }}"
               command: ["/entrypoint/entrypoint.sh"]
               args:
-                - --service="{{ include "imagepullsecret-injector.serviceName" . }}"
+                - --service "{{ include "imagepullsecret-injector.serviceName" . }}"
-                - --namespace="{{ .Release.Namespace }}"
+                - --namespace "{{ .Release.Namespace }}"
-                - --secret="{{ include "imagepullsecret-injector.certificateSecretName" . }}"
+                - --secret "{{ include "imagepullsecret-injector.certificateSecretName" . }}"
               volumeMounts:
                 - mountPath: "/entrypoint"
                   name: entrypoint

helm/imagepullsecret-injector/templates/certificate-gen/job-certificate-gen.yaml

@@ -14,9 +14,9 @@ spec:
           image: "{{ .Values.certificateGeneratorImage.registry }}/{{ .Values.certificateGeneratorImage.repository }}:{{ .Values.certificateGeneratorImage.tag | default .Chart.AppVersion }}"
           command: ["/entrypoint/entrypoint.sh"]
           args:
-            - --service="{{ include "imagepullsecret-injector.serviceName" . }}"
+            - --service "{{ include "imagepullsecret-injector.serviceName" . }}"
-            - --namespace="{{ .Release.Namespace }}"
+            - --namespace "{{ .Release.Namespace }}"
-            - --secret="{{ include "imagepullsecret-injector.certificateSecretName" . }}"
+            - --secret "{{ include "imagepullsecret-injector.certificateSecretName" . }}"
           volumeMounts:
             - mountPath: "/entrypoint"
               name: entrypoint

helm/imagepullsecret-injector/values.yaml

@@ -12,10 +12,10 @@ certificateGeneratorImage:
 
 imagepullsecretInjector:
   dockerconfigjsonRef:
-    secretName: my-cool-secret-source
+    secretName: acr-dockerconfigjson-source
     secretNamespace: ""
 
-  targetSecretName: my-cool-secret
+  targetSecretName: acr-dockerconfigjson
   ignoreSecretCreationError: false
   allSaNames: false
   saNames: