github-mirrors/Theatrical-Players-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/ysoftdevs/Theatrical-Players-Refactoring-Kata.git synced 2026-01-14 23:53:26 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

[PR #3] [MERGED] add html statement snapshot for JS #2

New Issue
Closed
opened 2025-12-31 16:38:42 +01:00 by adam · 0 comments
adam commented 2025-12-31 16:38:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ysoftdevs/Theatrical-Players-Refactoring-Kata/pull/3
Author: @raget
Created: 11/22/2021
Status: ✅ Merged
Merged: 11/25/2021
Merged by: @Svarcik

Base: main ← Head: js-html-snapshot

📝 Commits (1)

  • 716a8b7 add html statement snapshot for JS

📊 Changes

1 file changed (+14 additions, -0 deletions)

View changed files

➕ javascript/test/__snapshots__/htmlStatement.js.snap (+14 -0)

📄 Description

Added HTML statement snapshot for approval tests.
I didn't add the test for HTML because it could force developers to use a specific design. Test for HTML statement can be easily created from current statement tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ysoftdevs/Theatrical-Players-Refactoring-Kata/pull/3 **Author:** [@raget](https://github.com/raget) **Created:** 11/22/2021 **Status:** ✅ Merged **Merged:** 11/25/2021 **Merged by:** [@Svarcik](https://github.com/Svarcik) **Base:** `main` ← **Head:** `js-html-snapshot` --- ### 📝 Commits (1) - [`716a8b7`](https://github.com/ysoftdevs/Theatrical-Players-Refactoring-Kata/commit/716a8b7afbf8e945af3906e75b2cb0d7eb29c954) add html statement snapshot for JS ### 📊 Changes **1 file changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `javascript/test/__snapshots__/htmlStatement.js.snap` (+14 -0) </details> ### 📄 Description Added HTML statement snapshot for approval tests. I didn't add the test for HTML because it could force developers to use a specific design. Test for HTML statement can be easily created from current statement tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-31 16:38:42 +01:00
adam closed this issue 2025-12-31 16:38:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-mirrors/Theatrical-Players-Refactoring-Kata#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?