From 358dab1c5be56e7ac3afa5e00416c3110a009e62 Mon Sep 17 00:00:00 2001 From: Emily Bache Date: Wed, 7 Aug 2019 08:11:50 +0200 Subject: [PATCH] add acknowledgement --- README.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 8fe4214..63b709f 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ Theatrical Players Refactoring Kata ==================================== -The first chapter of ['Refactoring' by Martin Fowler, 2nd Edition](https://www.thoughtworks.com/books/refactoring2) contains a worked example of this exercise, in javascript. That chapter is available to download for free. This repo contains the starting point for this exercise in several languages, so you can try it out for yourself. +The first chapter of ['Refactoring' by Martin Fowler, 2nd Edition](https://www.thoughtworks.com/books/refactoring2) contains a worked example of this exercise, in javascript. That chapter is available to download for free. This repo contains the starting point for this exercise in several languages, with tests, so you can try it out for yourself. What you need to change ----------------------- @@ -9,4 +9,8 @@ Refactoring is usually driven by a need to make changes. In the book, Fowler add Automated tests --------------- -In his book Fowler mentions that the first step in refactoring is always the same - to ensure you have a solid set of tests for that section of code. However, Fowler did not include the test code for this example in his book. I have used an 'Approval' testing approach and added soem tests. I find Approval testing to be a powerful technique for rapidly getting existing code under test and to support refactoring. You should review these tests and make sure you understand what they cover and what kinds of refactoring mistakes they would expect to find. +In his book Fowler mentions that the first step in refactoring is always the same - to ensure you have a solid set of tests for that section of code. However, Fowler did not include the test code for this example in his book. I have used an 'Approval' testing approach and added some tests. I find Approval testing to be a powerful technique for rapidly getting existing code under test and to support refactoring. You should review these tests and make sure you understand what they cover and what kinds of refactoring mistakes they would expect to find. + +Acknowledgements +---------------- +Thankyou to Martin Fowler for kindly giving permission to use his code.