Hans Joachim Desserud
|
c7a763ffdc
|
Remove inheritance from Junit3 class and empty, unused methods
|
2015-09-13 17:01:32 +02:00 |
|
Hans Joachim Desserud
|
5435ddad9f
|
Place array designator on the type
|
2015-09-13 16:46:14 +02:00 |
|
Hans Joachim Desserud
|
0ecd466c4c
|
Add missing @Override annotations
|
2015-09-13 14:52:08 +02:00 |
|
Jeremy Long
|
58512e302f
|
resolved conflicts
|
2015-09-13 07:46:46 -04:00 |
|
Jeremy Long
|
290fdc4c0f
|
Merge pull request #350 from awhitford/AnalyzeIO
Replaced code with IOUtils.copy.
Thanks for the PR!
|
2015-09-13 07:40:41 -04:00 |
|
Jeremy Long
|
1fa5ae695d
|
Merge pull request #349 from hansjoachim/warnings
Fixes various warnings
|
2015-09-13 07:37:25 -04:00 |
|
Jeremy Long
|
620f1b94bc
|
added more false positive suppressions
|
2015-09-13 07:29:17 -04:00 |
|
Anthony Whitford
|
6e1c6b4bed
|
Replaced StringBuffer with more efficient StringBuilder.
|
2015-09-12 19:50:43 -07:00 |
|
Anthony Whitford
|
ce871dfa3e
|
Replaced code with IOUtils.copy.
|
2015-09-12 10:55:33 -07:00 |
|
Hans Joachim Desserud
|
48a6eb1f86
|
Prefer interfaces over concerete classes. Did not change return type for public methods as this might potentially cause problems/need for changes for external users
|
2015-09-12 15:35:56 +02:00 |
|
Hans Joachim Desserud
|
fb85fb5b76
|
Ensure that we assert something. If the iterator doesn't have any values we would never enter the loop, but the test would still be green
|
2015-09-12 15:03:41 +02:00 |
|
Hans Joachim Desserud
|
c39c3cfdae
|
Comment for review
|
2015-09-12 15:02:22 +02:00 |
|
Hans Joachim Desserud
|
e2fa7c666a
|
Unused variable
|
2015-09-12 14:53:01 +02:00 |
|
Hans Joachim Desserud
|
f49cc6fb1f
|
Unused methods in test
|
2015-09-12 14:51:49 +02:00 |
|
Hans Joachim Desserud
|
69bef59473
|
Remove superflous semicolon
|
2015-09-12 14:50:35 +02:00 |
|
Hans Joachim Desserud
|
ca5607d79e
|
Removed empty methods from test
|
2015-09-12 14:14:08 +02:00 |
|
Hans Joachim Desserud
|
903eaed250
|
Remove unused imports
|
2015-09-12 14:06:47 +02:00 |
|
Jeremy Long
|
388415ecc2
|
fixed hyperlink
|
2015-09-11 06:13:30 -04:00 |
|
Jeremy Long
|
44c5ba208d
|
added documentation about unused code
|
2015-09-11 05:31:09 -04:00 |
|
Anthony Whitford
|
11a3db5d64
|
Revert "Replaced update or insert property logic with merge property logic."
This reverts commit ece4a51b94.
|
2015-09-10 23:21:44 -07:00 |
|
Anthony Whitford
|
3746df49ee
|
Added type declarations.
|
2015-09-10 00:21:54 -07:00 |
|
Anthony Whitford
|
d98f67eab9
|
Added missing serialVersionUID.
|
2015-09-10 00:20:03 -07:00 |
|
Anthony Whitford
|
fde415e251
|
Added missing serialVersionUID.
|
2015-09-10 00:05:04 -07:00 |
|
Anthony Whitford
|
5702f39181
|
Addressed possible resource leak.
|
2015-09-09 23:54:20 -07:00 |
|
Anthony Whitford
|
45658afd89
|
Replaced empty string equals check with an isEmpty check.
|
2015-09-09 23:20:51 -07:00 |
|
Anthony Whitford
|
ece4a51b94
|
Replaced update or insert property logic with merge property logic.
|
2015-09-09 23:18:38 -07:00 |
|
Jeremy Long
|
fdbec176fa
|
fixed logging statements to use slf4j format syntax instead of String.format syntax
|
2015-09-08 06:31:59 -04:00 |
|
Anthony Whitford
|
96768d8529
|
Replaced Date manipulation with more efficient System call.
|
2015-09-08 01:01:13 -07:00 |
|
Anthony Whitford
|
2689a08026
|
Replaced Date manipulation with more efficient System call.
|
2015-09-07 17:50:02 -07:00 |
|
Anthony Whitford
|
54be70672e
|
Replaced Date manipulation with more efficient System call.
|
2015-09-07 17:49:11 -07:00 |
|
Anthony Whitford
|
b51731d15f
|
Added final keyword.
|
2015-09-07 16:35:23 -07:00 |
|
Anthony Whitford
|
769fcb20d8
|
Removed a now unused import.
|
2015-09-07 16:29:27 -07:00 |
|
Anthony Whitford
|
537c4b3a50
|
Added missing final keywords.
|
2015-09-07 16:28:55 -07:00 |
|
Anthony Whitford
|
a75c17ac5e
|
Added final keywords and elaborated the javax.json imports.
|
2015-09-07 16:28:22 -07:00 |
|
Anthony Whitford
|
85604e8afa
|
Logback-core is a transitive dependency from logback-classic -- no need to explicitly mention it. JSoup type is jar by default, so no need to mention that. SLF4J-Ext does not seem to be used, so can drop that. H2 only has runtime scope.
|
2015-09-07 16:01:10 -07:00 |
|
Anthony Whitford
|
9a45c9aa7c
|
Removed unused Cal10n MessageConveyor.
|
2015-09-07 15:21:54 -07:00 |
|
Anthony Whitford
|
01450bacc2
|
Removed a redundant null check, and replaced an addAll with the constructor population.
|
2015-09-07 14:51:26 -07:00 |
|
Anthony Whitford
|
af0255ee09
|
Rather than create a collection, then call addAll to populate, the collection can be created with the collection to clone.
|
2015-09-07 14:48:23 -07:00 |
|
Anthony Whitford
|
df25bbb6d2
|
Replaced json iteration with more efficient entrySet. Also corrected an invalid logging statement.
|
2015-09-07 14:43:34 -07:00 |
|
Anthony Whitford
|
444685bc05
|
Inner class should be static (since it doesn't reference parent).
|
2015-09-07 14:40:32 -07:00 |
|
Jeremy Long
|
1f48af024e
|
Merge pull request #338 from awhitford/PomCleanup
Pom cleanup
|
2015-09-07 07:34:07 -04:00 |
|
Anthony Whitford
|
514f8398e2
|
Upgraded commons-lang-2.6 to newer commons-lang3-3.4.
|
2015-09-07 01:09:41 -07:00 |
|
Anthony Whitford
|
6d70332cd6
|
Centralized the Versions report to the parent pom.
|
2015-09-06 22:21:50 -07:00 |
|
Anthony Whitford
|
717f6240e3
|
Centralized javadoc reporting to parent pom.
|
2015-09-06 20:51:56 -07:00 |
|
Anthony Whitford
|
d0f884f5b2
|
Centralized the maven-surefire-report-plugin to the parent pom. Note that gradle and jenkins modules are skipped since it does not apply.
|
2015-09-06 12:56:36 -07:00 |
|
Anthony Whitford
|
51e66354b0
|
No need to explicitly add a jar goal when it implicitly exists already for a jar module.
|
2015-09-06 11:18:56 -07:00 |
|
Anthony Whitford
|
a32fa69823
|
Moved taglist-maven-plugin to the parent pom. (Gradle and Jenkins modules don't have them -- before or after.) This will make it easier to manage and evolve.
|
2015-09-06 01:29:17 -07:00 |
|
Anthony Whitford
|
5c53b6528f
|
Centralized the findbugs-maven-plugin to the parent pom. Gradle and Jenkins modules skip it naturally. The onlyAnlyze setting for utils is maintained via a property. Also was able to upgrade to latest plugin, version 3.0.2.
|
2015-09-06 00:51:28 -07:00 |
|
Anthony Whitford
|
9b92007eff
|
Centralized cobertura plugin to the parent pom and was able to upgrade it from 2.6 to 2.7.
|
2015-09-06 00:23:24 -07:00 |
|
Anthony Whitford
|
e433809f4d
|
Moved maven-jxr-plugin and maven-project-info-reports-plugin reporting declarations into the parent pom. No need to duplicate in child modules. Utils did not have project-info reports, but there does not seem to be a good reason. Also note that the JXR plugin is naturally skipped when it does not apply (there is no java code), so not necessary to explicitly skip it for gradle and jenkins modules.
|
2015-09-05 23:57:53 -07:00 |
|