From f8867abe491cd0d7839c1727c194d94afe98e62c Mon Sep 17 00:00:00 2001 From: Jeremy Long Date: Sun, 13 Apr 2014 07:45:54 -0400 Subject: [PATCH] reordered operations Former-commit-id: 1a487bcc4400d881c8dda7118318b183a68a0fe3 --- .../analyzer/DependencyBundlingAnalyzer.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java index b18b0715a..227762ca9 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java @@ -106,18 +106,18 @@ public class DependencyBundlingAnalyzer extends AbstractAnalyzer implements Anal final ListIterator subIterator = engine.getDependencies().listIterator(mainIterator.nextIndex()); while (subIterator.hasNext()) { final Dependency nextDependency = subIterator.next(); - if (isShadedJar(dependency, nextDependency)) { - if (dependency.getFileName().toLowerCase().endsWith("pom.xml")) { - dependenciesToRemove.add(dependency); - } else { - dependenciesToRemove.add(nextDependency); - } - } else if (hashesMatch(dependency, nextDependency)) { + if (hashesMatch(dependency, nextDependency)) { if (isCore(dependency, nextDependency)) { mergeDependencies(dependency, nextDependency, dependenciesToRemove); } else { mergeDependencies(nextDependency, dependency, dependenciesToRemove); } + } else if (isShadedJar(dependency, nextDependency)) { + if (dependency.getFileName().toLowerCase().endsWith("pom.xml")) { + dependenciesToRemove.add(dependency); + } else { + dependenciesToRemove.add(nextDependency); + } } else if (cpeIdentifiersMatch(dependency, nextDependency) && hasSameBasePath(dependency, nextDependency) && fileNameMatch(dependency, nextDependency)) {