From ec6471e8c7526acf9c00afa7a6a9c2d011611669 Mon Sep 17 00:00:00 2001 From: Jeremy Long Date: Sun, 5 Jun 2016 17:17:38 -0400 Subject: [PATCH] added notes for future enhancment --- .../org/owasp/dependencycheck/analyzer/CPEAnalyzer.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/CPEAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/CPEAnalyzer.java index dc53ee3cd..6b4caef8e 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/CPEAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/CPEAnalyzer.java @@ -512,10 +512,11 @@ public class CPEAnalyzer implements Analyzer { Confidence bestGuessConf = null; boolean hasBroadMatch = false; final List collected = new ArrayList(); + + //TODO the following algorithm incorrectly identifies things as a lower version + // if there lower confidence evidence when the current (highest) version number + // is newer then anything in the NVD. for (Confidence conf : Confidence.values()) { -// if (conf.compareTo(currentConfidence) > 0) { -// break; -// } for (Evidence evidence : dependency.getVersionEvidence().iterator(conf)) { final DependencyVersion evVer = DependencyVersionUtil.parseVersion(evidence.getValue()); if (evVer == null) {