diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java index 8f645b0c9..e2eeb9bc3 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java @@ -116,7 +116,7 @@ public class Engine { * Loads the analyzers specified in the configuration file (or system properties). */ private void loadAnalyzers() { - if (analyzers.size() > 0) { + if (!analyzers.isEmpty()) { return; } for (AnalysisPhase phase : AnalysisPhase.values()) { diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/AbstractTokenizingFilter.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/AbstractTokenizingFilter.java index a45b653fe..6d06d74c6 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/AbstractTokenizingFilter.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/AbstractTokenizingFilter.java @@ -72,7 +72,7 @@ public abstract class AbstractTokenizingFilter extends TokenFilter { * @return whether or not a new term was added */ protected boolean addTerm() { - final boolean termAdded = tokens.size() > 0; + final boolean termAdded = !tokens.isEmpty(); if (termAdded) { final String term = tokens.pop(); clearAttributes(); diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilter.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilter.java index 3a5c52a8a..69c9c0769 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilter.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilter.java @@ -92,7 +92,7 @@ public final class TokenPairConcatenatingFilter extends TokenFilter { //if we have a previousTerm - write it out as its own token concatenated // with the current word (if one is available). - if (previousWord != null && words.size() > 0) { + if (previousWord != null && !words.isEmpty()) { final String word = words.getFirst(); clearAttributes(); termAtt.append(previousWord).append(word); @@ -100,7 +100,7 @@ public final class TokenPairConcatenatingFilter extends TokenFilter { return true; } //if we have words, write it out as a single token - if (words.size() > 0) { + if (!words.isEmpty()) { final String word = words.removeFirst(); clearAttributes(); termAtt.append(word); diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/UrlTokenizingFilter.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/UrlTokenizingFilter.java index e5f47221a..a02253123 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/UrlTokenizingFilter.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/lucene/UrlTokenizingFilter.java @@ -60,7 +60,7 @@ public final class UrlTokenizingFilter extends AbstractTokenizingFilter { public boolean incrementToken() throws IOException { final LinkedList tokens = getTokens(); final CharTermAttribute termAtt = getTermAtt(); - if (tokens.size() == 0 && input.incrementToken()) { + if (tokens.isEmpty() && input.incrementToken()) { final String text = new String(termAtt.buffer(), 0, termAtt.length()); if (UrlStringUtils.containsUrl(text)) { final String[] parts = text.split("\\s"); diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/CveDB.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/CveDB.java index 20473b646..d38da868c 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/CveDB.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/CveDB.java @@ -875,9 +875,9 @@ public class CveDB { */ private DependencyVersion parseDependencyVersion(VulnerableSoftware cpe) { DependencyVersion cpeVersion; - if (cpe.getVersion() != null && cpe.getVersion().length() > 0) { + if (cpe.getVersion() != null && !cpe.getVersion().isEmpty()) { String versionText; - if (cpe.getRevision() != null && cpe.getRevision().length() > 0) { + if (cpe.getRevision() != null && !cpe.getRevision().isEmpty()) { versionText = String.format("%s.%s", cpe.getVersion(), cpe.getRevision()); } else { versionText = cpe.getVersion(); diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/suppression/SuppressionRule.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/suppression/SuppressionRule.java index 90abfdec0..7d75a79c3 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/suppression/SuppressionRule.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/suppression/SuppressionRule.java @@ -112,7 +112,7 @@ public class SuppressionRule { * @return whether or not this suppression rule as CPE entries */ public boolean hasCpe() { - return cpe.size() > 0; + return !cpe.isEmpty(); } /** * The list of cvssBelow scores. @@ -152,7 +152,7 @@ public class SuppressionRule { * @return whether or not this suppression rule has cvss suppressions */ public boolean hasCvssBelow() { - return cvssBelow.size() > 0; + return !cvssBelow.isEmpty(); } /** * The list of cwe entries to suppress. @@ -192,7 +192,7 @@ public class SuppressionRule { * @return whether this suppression rule has CWE entries */ public boolean hasCwe() { - return cwe.size() > 0; + return !cwe.isEmpty(); } /** * The list of cve entries to suppress. @@ -232,7 +232,7 @@ public class SuppressionRule { * @return whether this suppression rule has CVE entries */ public boolean hasCve() { - return cve.size() > 0; + return !cve.isEmpty(); } /** * A Maven GAV to suppression. @@ -450,28 +450,28 @@ public class SuppressionRule { if (gav != null) { sb.append("gav=").append(gav).append(","); } - if (cpe != null && cpe.size() > 0) { + if (cpe != null && !cpe.isEmpty()) { sb.append("cpe={"); for (PropertyType pt : cpe) { sb.append(pt).append(","); } sb.append("}"); } - if (cwe != null && cwe.size() > 0) { + if (cwe != null && !cwe.isEmpty()) { sb.append("cwe={"); for (String s : cwe) { sb.append(s).append(","); } sb.append("}"); } - if (cve != null && cve.size() > 0) { + if (cve != null && !cve.isEmpty()) { sb.append("cve={"); for (String s : cve) { sb.append(s).append(","); } sb.append("}"); } - if (cvssBelow != null && cvssBelow.size() > 0) { + if (cvssBelow != null && !cvssBelow.isEmpty()) { sb.append("cvssBelow={"); for (Float s : cvssBelow) { sb.append(s).append(","); diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java index da32ae686..844ddbde6 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java @@ -701,7 +701,7 @@ public abstract class BaseDependencyCheckMojo extends AbstractMojo implements Ma private Proxy getMavenProxy() { if (mavenSettings != null) { final List proxies = mavenSettings.getProxies(); - if (proxies != null && proxies.size() > 0) { + if (proxies != null && !proxies.isEmpty()) { if (mavenSettingsProxyId != null) { for (Proxy proxy : proxies) { if (mavenSettingsProxyId.equalsIgnoreCase(proxy.getId())) { @@ -711,8 +711,8 @@ public abstract class BaseDependencyCheckMojo extends AbstractMojo implements Ma } else if (proxies.size() == 1) { return proxies.get(0); } else { - LOGGER.warning("Multiple proxy defentiions exist in the Maven settings. In the dependency-check " - + "configuration set the maveSettingsProxyId so that the correct proxy will be used."); + LOGGER.warning("Multiple proxy definitions exist in the Maven settings. In the dependency-check " + + "configuration set the mavenSettingsProxyId so that the correct proxy will be used."); throw new IllegalStateException("Ambiguous proxy definition"); } }