From cef3bb742424ab7c7640fdeab3bbb88bc20efe73 Mon Sep 17 00:00:00 2001 From: Anthony Whitford Date: Wed, 21 Oct 2015 23:27:03 -0700 Subject: [PATCH] Reworked withinDateRange to avoid type conversion between doubles and longs; expressed in long integer math. --- .../java/org/owasp/dependencycheck/utils/DateUtil.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DateUtil.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DateUtil.java index 9fbd33a4c..782b32379 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DateUtil.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DateUtil.java @@ -36,11 +36,12 @@ public final class DateUtil { * * @param date the date to be checked. * @param compareTo the date to compare to. - * @param range the range in days to be considered valid. + * @param dayRange the range in days to be considered valid. * @return whether or not the date is within the range. */ - public static boolean withinDateRange(long date, long compareTo, int range) { - final double differenceInDays = (compareTo - date) / 1000.0 / 60.0 / 60.0 / 24.0; - return differenceInDays < range; + public static boolean withinDateRange(long date, long compareTo, int dayRange) { + // ms = dayRange x 24 hours/day x 60 min/hour x 60 sec/min x 1000 ms/sec + final long msRange = dayRange * 24L * 60L * 60L * 1000L; + return (compareTo - date) < msRange; } }