From b24c63cb49a9d978e483c1e2ada07ec1b2785ddc Mon Sep 17 00:00:00 2001
From: Jeremy Long <jeremy.long@gmail.com>
Date: Wed, 16 Apr 2014 08:12:36 -0400
Subject: [PATCH] updated to support the new Settings implementation

Former-commit-id: 2e275cd7333b0e44b46745d5f51f89f3f1687b8f
---
 .../agent/DependencyCheckScanAgent.java           | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java
index 6e98f987e..96e289e07 100644
--- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java
+++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java
@@ -747,16 +747,9 @@ public class DependencyCheckScanAgent {
     private Engine executeDependencyCheck() throws DatabaseException {
         populateSettings();
         Engine engine = null;
-        try {
-            engine = new Engine();
-            engine.setDependencies(this.dependencies);
-            engine.analyzeDependencies();
-
-        } finally {
-            if (engine != null) {
-                engine.cleanup();
-            }
-        }
+        engine = new Engine();
+        engine.setDependencies(this.dependencies);
+        engine.analyzeDependencies();
         return engine;
     }
 
@@ -799,6 +792,7 @@ public class DependencyCheckScanAgent {
      * properties required to change the proxy url, port, and connection timeout.
      */
     private void populateSettings() {
+        Settings.initialize();
         if (dataDirectory != null) {
             Settings.setString(Settings.KEYS.DATA_DIRECTORY, dataDirectory);
         } else {
@@ -891,6 +885,7 @@ public class DependencyCheckScanAgent {
                     "Unable to connect to the dependency-check database; analysis has stopped");
             Logger.getLogger(DependencyCheckScanAgent.class.getName()).log(Level.FINE, "", ex);
         } finally {
+            Settings.cleanup();
             if (engine != null) {
                 engine.cleanup();
             }