From 9d5ff2809802d920357e493fcb19b8aa24550a56 Mon Sep 17 00:00:00 2001 From: Anthony Whitford Date: Mon, 28 Dec 2015 13:10:37 -0800 Subject: [PATCH] Variables can be final and the exception was unused so can be removed. --- .../data/update/nvd/DownloadTask.java | 28 ++----------------- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/nvd/DownloadTask.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/nvd/DownloadTask.java index 333f9aa4c..32cb44e81 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/nvd/DownloadTask.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/nvd/DownloadTask.java @@ -80,11 +80,11 @@ public class DownloadTask implements Callable> { /** * The CVE DB to use when processing the files. */ - private CveDB cveDB; + private final CveDB cveDB; /** * The processor service to pass the results of the download to. */ - private ExecutorService processorService; + private final ExecutorService processorService; /** * The NVD CVE Meta Data. */ @@ -92,7 +92,7 @@ public class DownloadTask implements Callable> { /** * A reference to the global settings object. */ - private Settings settings; + private final Settings settings; /** * Get the value of nvdCveInfo. @@ -155,28 +155,6 @@ public class DownloadTask implements Callable> { public void setSecond(File second) { this.second = second; } - /** - * A placeholder for an exception. - */ - private Exception exception = null; - - /** - * Get the value of exception. - * - * @return the value of exception - */ - public Exception getException() { - return exception; - } - - /** - * returns whether or not an exception occurred during download. - * - * @return whether or not an exception occurred during download - */ - public boolean hasException() { - return exception != null; - } @Override public Future call() throws Exception {