github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-03-27 11:31:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

rubygems: Add summary to evidence, inline constants that were only being used once.

Browse Source
This commit is contained in:
Dale Visser
2015-08-11 13:48:30 -04:00
parent 2d109b81cf
commit 89166e81fb
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/RubyGemspecAnalyzer.java
View File

@@ -26,7 +26,6 @@ import org.owasp.dependencycheck.dependency.EvidenceCollection;
import org.owasp.dependencycheck.utils.FileFilterBuilder; import org.owasp.dependencycheck.utils.FileFilterBuilder;
import org.owasp.dependencycheck.utils.Settings; import org.owasp.dependencycheck.utils.Settings;
import java.io.File;
import java.io.FileFilter; import java.io.FileFilter;
import java.io.IOException; import java.io.IOException;
import java.util.regex.Matcher; import java.util.regex.Matcher;
@@ -53,12 +52,8 @@ public class RubyGemspecAnalyzer extends AbstractFileTypeAnalyzer {
private static final FileFilter FILTER = private static final FileFilter FILTER =
FileFilterBuilder.newInstance().addExtensions("gemspec").addFilenames("Rakefile").build(); FileFilterBuilder.newInstance().addExtensions("gemspec").addFilenames("Rakefile").build();
private static final String AUTHORS = "authors";
private static final String NAME = "name";
private static final String EMAIL = "email"; private static final String EMAIL = "email";
private static final String HOMEPAGE = "homepage";
private static final String GEMSPEC = "gemspec"; private static final String GEMSPEC = "gemspec";
private static final String VERSION = "version";
/** /**
* @return a filter that accepts files named Rakefile or matching the glob pattern, *.gemspec * @return a filter that accepts files named Rakefile or matching the glob pattern, *.gemspec
@@ -124,18 +119,20 @@ public class RubyGemspecAnalyzer extends AbstractFileTypeAnalyzer {
contents = contents.substring(matcher.end()); contents = contents.substring(matcher.end());
final String blockVariable = matcher.group(1); final String blockVariable = matcher.group(1);
final EvidenceCollection vendor = dependency.getVendorEvidence(); final EvidenceCollection vendor = dependency.getVendorEvidence();
addListEvidence(vendor, contents, blockVariable, AUTHORS, Confidence.HIGHEST); addStringEvidence(vendor, contents, blockVariable, "author", Confidence.HIGHEST);
final String name = addStringEvidence( addListEvidence(vendor, contents, blockVariable, "authors", Confidence.HIGHEST);
dependency.getProductEvidence(), contents, blockVariable, NAME, Confidence.HIGHEST);
if (!name.isEmpty()) {
vendor.addEvidence(GEMSPEC, "name_project", name + "_project", Confidence.LOW);
}
final String email = addStringEvidence(vendor, contents, blockVariable, EMAIL, Confidence.MEDIUM); final String email = addStringEvidence(vendor, contents, blockVariable, EMAIL, Confidence.MEDIUM);
if (email.isEmpty()) { if (email.isEmpty()) {
addListEvidence(vendor, contents, blockVariable, EMAIL, Confidence.MEDIUM); addListEvidence(vendor, contents, blockVariable, EMAIL, Confidence.MEDIUM);
} }
addStringEvidence(vendor, contents, blockVariable, HOMEPAGE, Confidence.MEDIUM); addStringEvidence(vendor, contents, blockVariable, "homepage", Confidence.MEDIUM);
addStringEvidence(dependency.getVersionEvidence(), contents, blockVariable, VERSION, Confidence.HIGHEST); final EvidenceCollection product = dependency.getProductEvidence();
final String name = addStringEvidence(product, contents, blockVariable, "name", Confidence.HIGHEST);
if (!name.isEmpty()) {
vendor.addEvidence(GEMSPEC, "name_project", name + "_project", Confidence.LOW);
}
addStringEvidence(product, contents, blockVariable, "summary", Confidence.LOW);
addStringEvidence(dependency.getVersionEvidence(), contents, blockVariable, "version", Confidence.HIGHEST);
} }
} }