github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-03-26 19:11:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Extracted magic numbers in hashCode() to named constants.

Browse Source 
Former-commit-id: e023cdf8583859215243244227bdc576b4df75f4
This commit is contained in:
Dale Visser
2015-06-19 13:47:03 -04:00
parent 7e2720e673
commit 77ae9dfbef
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Dependency.java
View File

@@ -48,6 +48,14 @@ public class Dependency implements Serializable, Comparable<Dependency> {
* The logger. * The logger.
*/ */
private static final Logger LOGGER = LoggerFactory.getLogger(Dependency.class); private static final Logger LOGGER = LoggerFactory.getLogger(Dependency.class);
/**
* Used as starting point for generating the value in {@link #hashCode()}.
*/
private static final int MAGIC_HASH_INIT_VALUE = 3;
/**
* Used as a multiplier for generating the value in {@link #hashCode()}.
*/
private static final int MAGIC_HASH_MULTIPLIER = 47;
/** /**
* The actual file path of the dependency on disk. * The actual file path of the dependency on disk.
*/ */
@@ -752,12 +760,12 @@ public class Dependency implements Serializable, Comparable<Dependency> {
*/ */
@Override @Override
public int hashCode() { public int hashCode() {
int hash = 3; int hash = MAGIC_HASH_INIT_VALUE;
for (Object field : new Object[]{this.actualFilePath, this.filePath, this.fileName, this.fileExtension, this.md5sum, for (Object field : new Object[]{this.actualFilePath, this.filePath, this.fileName, this.fileExtension, this.md5sum,
this.sha1sum, this.identifiers, this.vendorEvidence, this.productEvidence, this.versionEvidence, this.sha1sum, this.identifiers, this.vendorEvidence, this.productEvidence, this.versionEvidence,
this.description, this.license, this.vulnerabilities, this.relatedDependencies, this.projectReferences, this.description, this.license, this.vulnerabilities, this.relatedDependencies, this.projectReferences,
this.availableVersions}) { this.availableVersions}) {
hash = 47 * hash + ObjectUtils.hashCode(field); hash = MAGIC_HASH_MULTIPLIER * hash + ObjectUtils.hashCode(field);
} }
return hash; return hash;
} }