ensured resources are properly closed

This commit is contained in:
Jeremy Long
2016-05-15 07:02:18 -04:00
parent 6f451736ba
commit 6790727260

View File

@@ -225,8 +225,9 @@ public class RubyBundleAuditAnalyzer extends AbstractFileTypeAnalyzer {
throw new AnalysisException("bundle-audit process interrupted", ie); throw new AnalysisException("bundle-audit process interrupted", ie);
} }
BufferedReader rdr = null; BufferedReader rdr = null;
BufferedReader errReader = null;
try { try {
BufferedReader errReader = new BufferedReader(new InputStreamReader(process.getErrorStream(), "UTF-8")); errReader = new BufferedReader(new InputStreamReader(process.getErrorStream(), "UTF-8"));
while (errReader.ready()) { while (errReader.ready()) {
String error = errReader.readLine(); String error = errReader.readLine();
LOGGER.warn(error); LOGGER.warn(error);
@@ -236,6 +237,13 @@ public class RubyBundleAuditAnalyzer extends AbstractFileTypeAnalyzer {
} catch (IOException ioe) { } catch (IOException ioe) {
LOGGER.warn("bundle-audit failure", ioe); LOGGER.warn("bundle-audit failure", ioe);
} finally { } finally {
if (errReader!= null) {
try {
errReader.close();
} catch (IOException ioe) {
LOGGER.warn("bundle-audit close failure", ioe);
}
}
if (null != rdr) { if (null != rdr) {
try { try {
rdr.close(); rdr.close();