From 5db377923efac5a1517c3fc1b2a575ecbbaec0d4 Mon Sep 17 00:00:00 2001 From: Anthony Whitford Date: Sun, 11 Oct 2015 16:51:57 -0700 Subject: [PATCH 1/2] Sized the new HashSet to avoid rehashing risk. --- .../dependencycheck/analyzer/AbstractFileTypeAnalyzer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/AbstractFileTypeAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/AbstractFileTypeAnalyzer.java index 6f23a75b2..26d8d8ab8 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/AbstractFileTypeAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/AbstractFileTypeAnalyzer.java @@ -214,7 +214,7 @@ public abstract class AbstractFileTypeAnalyzer extends AbstractAnalyzer implemen * @return a Set of strings. */ protected static Set newHashSet(String... strings) { - final Set set = new HashSet(); + final Set set = new HashSet(strings.length); Collections.addAll(set, strings); return set; } From 762b2fe7d62eed45374c3a253032f9b0cca66e8b Mon Sep 17 00:00:00 2001 From: Anthony Whitford Date: Sun, 11 Oct 2015 17:32:08 -0700 Subject: [PATCH 2/2] Leverage Collections.singleton for single entry HashSets. --- .../analyzer/CPEAnalyzerIntegrationTest.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CPEAnalyzerIntegrationTest.java b/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CPEAnalyzerIntegrationTest.java index 6e272206e..0384fe407 100644 --- a/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CPEAnalyzerIntegrationTest.java +++ b/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CPEAnalyzerIntegrationTest.java @@ -19,7 +19,7 @@ package org.owasp.dependencycheck.analyzer; import java.io.File; import java.io.IOException; -import java.util.HashSet; +import java.util.Collections; import java.util.List; import java.util.Set; import org.apache.lucene.index.CorruptIndexException; @@ -49,11 +49,9 @@ public class CPEAnalyzerIntegrationTest extends AbstractDatabaseTestCase { */ @Test public void testBuildSearch() throws IOException, CorruptIndexException, ParseException { - Set productWeightings = new HashSet(1); - productWeightings.add("struts2"); + Set productWeightings = Collections.singleton("struts2"); - Set vendorWeightings = new HashSet(1); - vendorWeightings.add("apache"); + Set vendorWeightings = Collections.singleton("apache"); String vendor = "apache software foundation"; String product = "struts 2 core"; @@ -238,11 +236,9 @@ public class CPEAnalyzerIntegrationTest extends AbstractDatabaseTestCase { CPEAnalyzer instance = new CPEAnalyzer(); instance.open(); - Set productWeightings = new HashSet(1); - productWeightings.add("struts2"); + Set productWeightings = Collections.singleton("struts2"); - Set vendorWeightings = new HashSet(1); - vendorWeightings.add("apache"); + Set vendorWeightings = Collections.singleton("apache"); List result = instance.searchCPE(vendor, product, productWeightings, vendorWeightings); instance.close();