From 535d1e4aff80ade7b2406b705529699fd4e27ea3 Mon Sep 17 00:00:00 2001
From: Jeremy Long
Date: Tue, 4 Jun 2013 23:47:22 -0400
Subject: [PATCH] checkstle fixes
Former-commit-id: d7f55af71bca0347b03db5fb9660c3b391619100
---
.../org/owasp/dependencycheck/analyzer/JarAnalyzer.java | 2 +-
.../owasp/dependencycheck/data/nvdcve/NvdCveAnalyzer.java | 6 +++---
.../owasp/dependencycheck/reporting/ReportGenerator.java | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java b/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
index 0161e4143..de0da3368 100644
--- a/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
+++ b/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
@@ -810,7 +810,7 @@ public class JarAnalyzer extends AbstractAnalyzer implements Analyzer {
HashMap level1, HashMap level2, HashMap level3) {
int count = 0;
while (en.hasMoreElements()) {
- final java.util.jar.JarEntry entry = (java.util.jar.JarEntry) en.nextElement();
+ final JarEntry entry = (JarEntry) en.nextElement();
if (entry.getName().endsWith(".class")) {
String[] path;
if (entry.getName().contains("/")) {
diff --git a/src/main/java/org/owasp/dependencycheck/data/nvdcve/NvdCveAnalyzer.java b/src/main/java/org/owasp/dependencycheck/data/nvdcve/NvdCveAnalyzer.java
index cf75d98f8..89fda1660 100644
--- a/src/main/java/org/owasp/dependencycheck/data/nvdcve/NvdCveAnalyzer.java
+++ b/src/main/java/org/owasp/dependencycheck/data/nvdcve/NvdCveAnalyzer.java
@@ -169,9 +169,9 @@ public class NvdCveAnalyzer implements Analyzer {
* Specifically, this is concerned with ensuring the version numbers are correct.
* Currently, this is focused on the issues with the versions for Struts 1 and Struts 2.
* In the future this will due better matching on more version numbers.
- * @param dependency
- * @param v
- * @return
+ * @param dependency the dependency
+ * @param v the vulnerability
+ * @return returns true if the vulnerability is for the given dependency
*/
private boolean isValidMatch(final Dependency dependency, final Vulnerability v) {
//right now I only know of the issue with Struts1/2
diff --git a/src/main/java/org/owasp/dependencycheck/reporting/ReportGenerator.java b/src/main/java/org/owasp/dependencycheck/reporting/ReportGenerator.java
index 7b3e592b8..d56a23588 100644
--- a/src/main/java/org/owasp/dependencycheck/reporting/ReportGenerator.java
+++ b/src/main/java/org/owasp/dependencycheck/reporting/ReportGenerator.java
@@ -198,7 +198,7 @@ public class ReportGenerator {
try {
final File outDir = new File(outFileName).getParentFile();
if (!outDir.exists()) {
- boolean created = outDir.mkdirs();
+ final boolean created = outDir.mkdirs();
if (!created) {
throw new Exception("Unable to create directory '" + outDir.getAbsolutePath() + "'.");
}