github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-03-21 00:29:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

removed additional false positives as part of patch for issue #93 and #119

Browse Source 
Former-commit-id: 1d9275cc6f466beaa18a362515be98bafe9608b3
This commit is contained in:
Jeremy Long
2014-05-10 06:56:53 -04:00
parent 07bc94f9f6
commit 37b0612d45
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FalsePositiveAnalyzer.java
View File

@@ -88,7 +88,7 @@ public class FalsePositiveAnalyzer extends AbstractAnalyzer {
removeBadMatches(dependency); removeBadMatches(dependency);
removeWrongVersionMatches(dependency); removeWrongVersionMatches(dependency);
removeSpuriousCPE(dependency); removeSpuriousCPE(dependency);
removeDuplicativePOMEntries(dependency, engine); removeDuplicativeEntriesFromJar(dependency, engine);
addFalseNegativeCPEs(dependency); addFalseNegativeCPEs(dependency);
} }
@@ -338,8 +338,17 @@ public class FalsePositiveAnalyzer extends AbstractAnalyzer {
} }
} }
private void removeDuplicativePOMEntries(Dependency dependency, Engine engine) { /**
if (dependency.getFileName().toLowerCase().endsWith("pom.xml")) { * Removes duplicate entries identified that are contained within JAR files. These occasionally crop up due to POM
* entries or other types of files (such as DLLs and EXEs) being contained within the JAR.
*
* @param dependency the dependency that might be a duplicate
* @param engine the engine used to scan all dependencies
*/
private void removeDuplicativeEntriesFromJar(Dependency dependency, Engine engine) {
if (dependency.getFileName().toLowerCase().endsWith("pom.xml")
|| dependency.getFileExtension().equals("dll")
|| dependency.getFileExtension().equals("exe")) {
String parentPath = dependency.getFilePath().toLowerCase(); String parentPath = dependency.getFilePath().toLowerCase();
if (parentPath.contains(".jar")) { if (parentPath.contains(".jar")) {
parentPath = parentPath.substring(0, parentPath.indexOf(".jar") + 4); parentPath = parentPath.substring(0, parentPath.indexOf(".jar") + 4);