From 35d0f21c47cc11173a00a37a188d138efd16da27 Mon Sep 17 00:00:00 2001 From: Jeremy Long Date: Sat, 1 Apr 2017 10:02:24 -0400 Subject: [PATCH] fix codacy issues --- .../taskdefs/DependencyCheckTaskTest.java | 9 ++------- .../java/org/owasp/dependencycheck/BaseDBTestCase.java | 2 -- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/dependency-check-ant/src/test/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTaskTest.java b/dependency-check-ant/src/test/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTaskTest.java index 04a6b4c44..ffab315f3 100644 --- a/dependency-check-ant/src/test/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTaskTest.java +++ b/dependency-check-ant/src/test/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTaskTest.java @@ -30,8 +30,6 @@ import org.owasp.dependencycheck.BaseDBTestCase; import org.owasp.dependencycheck.utils.Settings; import static org.junit.Assert.assertTrue; -import org.owasp.dependencycheck.data.nvdcve.CveDB; -import org.owasp.dependencycheck.data.nvdcve.DatabaseException; /** * @@ -66,13 +64,10 @@ public class DependencyCheckTaskTest { @Test public void testAddFileSet() throws Exception { File report = new File("target/dependency-check-report.html"); - if (report.exists()) { - if (!report.delete()) { - throw new Exception("Unable to delete 'target/DependencyCheck-Report.html' prior to test."); - } + if (report.exists() && !report.delete()) { + throw new Exception("Unable to delete 'target/DependencyCheck-Report.html' prior to test."); } buildFileRule.executeTarget("test.fileset"); - assertTrue("DependencyCheck report was not generated", report.exists()); } diff --git a/dependency-check-core/src/test/java/org/owasp/dependencycheck/BaseDBTestCase.java b/dependency-check-core/src/test/java/org/owasp/dependencycheck/BaseDBTestCase.java index df1b910c2..bfcb5cb5a 100644 --- a/dependency-check-core/src/test/java/org/owasp/dependencycheck/BaseDBTestCase.java +++ b/dependency-check-core/src/test/java/org/owasp/dependencycheck/BaseDBTestCase.java @@ -25,9 +25,7 @@ import java.io.FileOutputStream; import java.util.zip.ZipEntry; import java.util.zip.ZipInputStream; import org.apache.commons.compress.utils.IOUtils; -import org.junit.AfterClass; import org.junit.Before; -import org.owasp.dependencycheck.data.nvdcve.CveDB; import org.owasp.dependencycheck.utils.Settings; import org.slf4j.Logger; import org.slf4j.LoggerFactory;