github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-03-23 01:29:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

AutoconfAnalyzer: Minor code fixes to address some static analysis warnings.

Browse Source 
Former-commit-id: a8ad815fd8fbcf1b21141093d92da0758c344d01
This commit is contained in:
Dale Visser
2015-05-20 18:57:54 -04:00
parent e960fd31fa
commit 29fe71b82c
1 changed files with 21 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/AutoconfAnalyzer.java
View File

@@ -42,10 +42,19 @@ import org.owasp.dependencycheck.utils.UrlStringUtils;
public class AutoconfAnalyzer extends AbstractFileTypeAnalyzer { public class AutoconfAnalyzer extends AbstractFileTypeAnalyzer {
/** /**
* Used when compiling file scanning regex patterns. * The name of the analyzer.
*/ */
private static final int REGEX_OPTIONS = Pattern.DOTALL private static final String ANALYZER_NAME = "Autoconf Analyzer";
| Pattern.CASE_INSENSITIVE;
/**
* The phase that this analyzer is intended to run in.
*/
private static final AnalysisPhase ANALYSIS_PHASE = AnalysisPhase.INFORMATION_COLLECTION;
/**
* The set of file extensions supported by this analyzer.
*/
private static final Set<String> EXTENSIONS = newHashSet("ac");
/** /**
* Matches AC_INIT statement in configure.ac file. * Matches AC_INIT statement in configure.ac file.
@@ -65,23 +74,10 @@ public class AutoconfAnalyzer extends AbstractFileTypeAnalyzer {
// Group 8: URL (if it exists) // Group 8: URL (if it exists)
AC_INIT_PATTERN = Pattern.compile(String.format( AC_INIT_PATTERN = Pattern.compile(String.format(
"AC_INIT\\(%s%s(%s)?(%s)?(%s)?", param, sep_param, sep_param, "AC_INIT\\(%s%s(%s)?(%s)?(%s)?", param, sep_param, sep_param,
sep_param, sep_param), REGEX_OPTIONS); sep_param, sep_param), Pattern.DOTALL
| Pattern.CASE_INSENSITIVE);
} }
/**
* The name of the analyzer.
*/
private static final String ANALYZER_NAME = "Autoconf Analyzer";
/**
* The phase that this analyzer is intended to run in.
*/
private static final AnalysisPhase ANALYSIS_PHASE = AnalysisPhase.INFORMATION_COLLECTION;
/**
* The set of file extensions supported by this analyzer.
*/
private static final Set<String> EXTENSIONS = newHashSet("ac");
/** /**
* Returns a list of file EXTENSIONS supported by this analyzer. * Returns a list of file EXTENSIONS supported by this analyzer.
* *
@@ -159,7 +155,7 @@ public class AutoconfAnalyzer extends AbstractFileTypeAnalyzer {
matcher.group(6), Confidence.HIGH); matcher.group(6), Confidence.HIGH);
} }
if (null != matcher.group(7)) { if (null != matcher.group(7)) {
String url = matcher.group(8); final String url = matcher.group(8);
if (UrlStringUtils.isUrl(url)) { if (UrlStringUtils.isUrl(url)) {
vendorEvidence.addEvidence(name, "URL", url, vendorEvidence.addEvidence(name, "URL", url,
Confidence.HIGH); Confidence.HIGH);
@@ -170,16 +166,14 @@ public class AutoconfAnalyzer extends AbstractFileTypeAnalyzer {
} }
} }
@Override
protected void initializeFileTypeAnalyzer() throws Exception {
// TODO add useful initialization here
}
/** /**
* Deletes any files extracted from the Wheel during analysis. * Initializes the file type analyzer.
*
* @throws Exception
* thrown if there is an exception during initialization
*/ */
@Override @Override
public void close() { protected void initializeFileTypeAnalyzer() throws Exception {
// TODO useful close operations here // No initialization needed.
} }
} }