From 2689a08026c884fd25a40efc16de75ce23d452aa Mon Sep 17 00:00:00 2001 From: Anthony Whitford Date: Mon, 7 Sep 2015 17:50:02 -0700 Subject: [PATCH] Replaced Date manipulation with more efficient System call. --- .../owasp/dependencycheck/data/update/CpeUpdater.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/CpeUpdater.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/CpeUpdater.java index 0f6707488..e773f0f15 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/CpeUpdater.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/update/CpeUpdater.java @@ -24,7 +24,6 @@ import java.io.FileOutputStream; import java.io.IOException; import java.net.MalformedURLException; import java.net.URL; -import java.util.Date; import java.util.List; import java.util.zip.GZIPInputStream; import javax.xml.parsers.ParserConfigurationException; @@ -69,8 +68,8 @@ public class CpeUpdater extends BaseUpdater implements CachedWebDataSource { for (Cpe cpe : cpes) { getCveDB().addCpe(cpe.getValue(), cpe.getVendor(), cpe.getProduct()); } - final Date now = new Date(); - getProperties().save(LAST_CPE_UPDATE, Long.toString(now.getTime())); + final long now = System.currentTimeMillis(); + getProperties().save(LAST_CPE_UPDATE, Long.toString(now)); LOGGER.info("CPE update complete"); } } finally { @@ -134,14 +133,14 @@ public class CpeUpdater extends BaseUpdater implements CachedWebDataSource { * @return true if the CPE data should be refreshed */ private boolean updateNeeded() { - final Date now = new Date(); + final long now = System.currentTimeMillis(); final int days = Settings.getInt(Settings.KEYS.CVE_MODIFIED_VALID_FOR_DAYS, 30); long timestamp = 0; final String ts = getProperties().getProperty(LAST_CPE_UPDATE); if (ts != null && ts.matches("^[0-9]+$")) { timestamp = Long.parseLong(ts); } - return !DateUtil.withinDateRange(timestamp, now.getTime(), days); + return !DateUtil.withinDateRange(timestamp, now, days); } /**