From 0f3845b16d749f44b7ca7b924d947307d53c9652 Mon Sep 17 00:00:00 2001
From: Stefan Neuhaus <dr.stefan.neuhaus@gmail.com>
Date: Mon, 20 Feb 2017 18:59:15 +0100
Subject: [PATCH] cleanup: remove unused return value

---
 .../dependencycheck/dependency/Vulnerability.java | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java
index aac408a02..ae4c334b2 100644
--- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java
+++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java
@@ -194,10 +194,9 @@ public class Vulnerability implements Serializable, Comparable<Vulnerability> {
      * Adds an entry for vulnerable software.
      *
      * @param cpe string representation of a CPE entry
-     * @return if the add succeeded
      */
-    public boolean addVulnerableSoftware(String cpe) {
-        return addVulnerableSoftware(cpe, null);
+    public void addVulnerableSoftware(String cpe) {
+        addVulnerableSoftware(cpe, null);
     }
 
     /**
@@ -206,28 +205,26 @@ public class Vulnerability implements Serializable, Comparable<Vulnerability> {
      * @param cpe string representation of a cpe
      * @param previousVersion the previous version (previousVersion - cpe would
      * be considered vulnerable)
-     * @return if the add succeeded
      */
-    public boolean addVulnerableSoftware(String cpe, String previousVersion) {
+    public void addVulnerableSoftware(String cpe, String previousVersion) {
         final VulnerableSoftware vs = new VulnerableSoftware();
         vs.setCpe(cpe);
         if (previousVersion != null) {
             vs.setPreviousVersion(previousVersion);
         }
-        return updateVulnerableSoftware(vs);
+        updateVulnerableSoftware(vs);
     }
 
     /**
      * Adds or updates a vulnerable software entry.
      *
      * @param vulnSoftware the vulnerable software
-     * @return if the update succeeded
      */
-    public boolean updateVulnerableSoftware(VulnerableSoftware vulnSoftware) {
+    public void updateVulnerableSoftware(VulnerableSoftware vulnSoftware) {
         if (vulnerableSoftware.contains(vulnSoftware)) {
             vulnerableSoftware.remove(vulnSoftware);
         }
-        return vulnerableSoftware.add(vulnSoftware);
+        vulnerableSoftware.add(vulnSoftware);
     }
 
     /**