diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java index d6bf1d839..58b2712d7 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/Engine.java @@ -479,6 +479,7 @@ public class Engine implements FileFilter { * @param file a file extension * @return true or false depending on whether or not the file extension is supported */ + @Override public boolean accept(File file) { if (file == null) { return false; diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java index 26ad7b3da..4c74b36cf 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/DependencyBundlingAnalyzer.java @@ -75,6 +75,7 @@ public class DependencyBundlingAnalyzer extends AbstractAnalyzer implements Anal * * @return the name of the analyzer. */ + @Override public String getName() { return ANALYZER_NAME; } @@ -84,6 +85,7 @@ public class DependencyBundlingAnalyzer extends AbstractAnalyzer implements Anal * * @return the phase that the analyzer is intended to run in. */ + @Override public AnalysisPhase getAnalysisPhase() { return ANALYSIS_PHASE; } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FalsePositiveAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FalsePositiveAnalyzer.java index d136ee235..0a92968b7 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FalsePositiveAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FalsePositiveAnalyzer.java @@ -69,6 +69,7 @@ public class FalsePositiveAnalyzer extends AbstractAnalyzer { * * @return the name of the analyzer. */ + @Override public String getName() { return ANALYZER_NAME; } @@ -78,6 +79,7 @@ public class FalsePositiveAnalyzer extends AbstractAnalyzer { * * @return the phase that the analyzer is intended to run in. */ + @Override public AnalysisPhase getAnalysisPhase() { return ANALYSIS_PHASE; } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FileNameAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FileNameAnalyzer.java index 529c9ecce..645afce07 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FileNameAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/FileNameAnalyzer.java @@ -48,6 +48,7 @@ public class FileNameAnalyzer extends AbstractAnalyzer implements Analyzer { * * @return the name of the analyzer. */ + @Override public String getName() { return ANALYZER_NAME; } @@ -57,6 +58,7 @@ public class FileNameAnalyzer extends AbstractAnalyzer implements Analyzer { * * @return the phase that the analyzer is intended to run in. */ + @Override public AnalysisPhase getAnalysisPhase() { return ANALYSIS_PHASE; } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java index f71e19624..01f2eabc0 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java @@ -195,6 +195,7 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer { * * @return the phase that the analyzer is intended to run in. */ + @Override public AnalysisPhase getAnalysisPhase() { return ANALYSIS_PHASE; } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/DriverShim.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/DriverShim.java index 6744f6a80..073c7cff8 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/DriverShim.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nvdcve/DriverShim.java @@ -116,6 +116,7 @@ class DriverShim implements Driver { * @see java.sql.Driver#getParentLogger() */ //@Override + @Override public java.util.logging.Logger getParentLogger() throws SQLFeatureNotSupportedException { //return driver.getParentLogger(); Method m = null; diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Dependency.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Dependency.java index a847aba13..2e6d93bb0 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Dependency.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Dependency.java @@ -696,6 +696,7 @@ public class Dependency implements Serializable, Comparable { * @param o a dependency to compare * @return an integer representing the natural ordering */ + @Override public int compareTo(Dependency o) { return this.getFilePath().compareToIgnoreCase(o.getFilePath()); } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Evidence.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Evidence.java index e95fe7d11..23eb6e2d8 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Evidence.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Evidence.java @@ -234,6 +234,7 @@ public class Evidence implements Serializable, Comparable { * @param o the evidence being compared * @return an integer indicating the ordering of the two objects */ + @Override public int compareTo(Evidence o) { if (o == null) { return 1; diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/EvidenceCollection.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/EvidenceCollection.java index eabfee9ed..59c0431a7 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/EvidenceCollection.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/EvidenceCollection.java @@ -51,6 +51,7 @@ public class EvidenceCollection implements Serializable, Iterable { * Used to iterate over highest confidence evidence contained in the collection. */ private static final Filter HIGHEST_CONFIDENCE = new Filter() { + @Override public boolean passes(Evidence evidence) { return evidence.getConfidence() == Confidence.HIGHEST; } @@ -59,6 +60,7 @@ public class EvidenceCollection implements Serializable, Iterable { * Used to iterate over high confidence evidence contained in the collection. */ private static final Filter HIGH_CONFIDENCE = new Filter() { + @Override public boolean passes(Evidence evidence) { return evidence.getConfidence() == Confidence.HIGH; } @@ -67,6 +69,7 @@ public class EvidenceCollection implements Serializable, Iterable { * Used to iterate over medium confidence evidence contained in the collection. */ private static final Filter MEDIUM_CONFIDENCE = new Filter() { + @Override public boolean passes(Evidence evidence) { return evidence.getConfidence() == Confidence.MEDIUM; } @@ -75,6 +78,7 @@ public class EvidenceCollection implements Serializable, Iterable { * Used to iterate over low confidence evidence contained in the collection. */ private static final Filter LOW_CONFIDENCE = new Filter() { + @Override public boolean passes(Evidence evidence) { return evidence.getConfidence() == Confidence.LOW; } @@ -83,6 +87,7 @@ public class EvidenceCollection implements Serializable, Iterable { * Used to iterate over evidence that has was used (aka read) from the collection. */ private static final Filter EVIDENCE_USED = new Filter() { + @Override public boolean passes(Evidence evidence) { return evidence.isUsed(); } @@ -222,6 +227,7 @@ public class EvidenceCollection implements Serializable, Iterable { * * @return an Iterator. */ + @Override public Iterator iterator() { return list.iterator(); } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Identifier.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Identifier.java index ff09efeb9..d5569d5f9 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Identifier.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Identifier.java @@ -221,6 +221,7 @@ public class Identifier implements Serializable, Comparable { * @param o the object being compared * @return an integer indicating the ordering */ + @Override public int compareTo(Identifier o) { if (o == null) { return -1; diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Reference.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Reference.java index 67702a084..e8db33f17 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Reference.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Reference.java @@ -133,6 +133,7 @@ public class Reference implements Serializable, Comparable { * @param o the Reference being compared * @return an integer indicating the ordering of the two objects */ + @Override public int compareTo(Reference o) { if (source.equals(o.source)) { if (name.equals(o.name)) { diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java index 8787b3b32..9fc097401 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Vulnerability.java @@ -390,6 +390,7 @@ public class Vulnerability implements Serializable, Comparable { * @return a negative integer, zero, or a positive integer as this object is less than, equal to, or greater than * the specified vulnerability */ + @Override public int compareTo(Vulnerability v) { return v.getName().compareTo(this.getName()); } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/VulnerabilityComparator.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/VulnerabilityComparator.java index 020888afd..3ce8e5a32 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/VulnerabilityComparator.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/VulnerabilityComparator.java @@ -39,6 +39,7 @@ public class VulnerabilityComparator implements Comparator, Seria * @param o2 a second vulnerability * @return the comparison */ + @Override public int compare(Vulnerability o1, Vulnerability o2) { return o2.getName().compareTo(o1.getName()); } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/reporting/VelocityLoggerRedirect.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/reporting/VelocityLoggerRedirect.java index f846b29c8..5aa633fae 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/reporting/VelocityLoggerRedirect.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/reporting/VelocityLoggerRedirect.java @@ -46,6 +46,7 @@ public class VelocityLoggerRedirect implements LogChute { * * @param rsvc the RuntimeServices */ + @Override public void init(RuntimeServices rsvc) { // do nothing } @@ -57,6 +58,7 @@ public class VelocityLoggerRedirect implements LogChute { * @param level the logging level * @param message the message to be logged */ + @Override public void log(int level, String message) { switch (level) { case TRACE_ID: @@ -87,6 +89,7 @@ public class VelocityLoggerRedirect implements LogChute { * @param message the message to be logged * @param t a throwable to log */ + @Override public void log(int level, String message, Throwable t) { switch (level) { case TRACE_ID: @@ -115,6 +118,7 @@ public class VelocityLoggerRedirect implements LogChute { * @param level the logging level * @return true */ + @Override public boolean isLevelEnabled(int level) { return true; } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DependencyVersion.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DependencyVersion.java index ec1036d28..83df787f5 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DependencyVersion.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/DependencyVersion.java @@ -103,6 +103,7 @@ public class DependencyVersion implements Iterable, Comparable iterator() { return versionParts.iterator(); } diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/Filter.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/Filter.java index f4d932d3c..4e4287f7d 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/Filter.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/utils/Filter.java @@ -23,6 +23,7 @@ public abstract class Filter { public Iterable filter(final Iterable iterable) { return new Iterable() { + @Override public Iterator iterator() { return filter(iterable.iterator()); } @@ -39,10 +40,12 @@ public abstract class Filter { toNext(); } + @Override public boolean hasNext() { return next != null; } + @Override public T next() { if (next == null) { throw new NoSuchElementException(); @@ -52,6 +55,7 @@ public abstract class Filter { return returnValue; } + @Override public void remove() { throw new UnsupportedOperationException(); } diff --git a/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CMakeAnalyzerTest.java b/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CMakeAnalyzerTest.java index 1d5186c39..fcde64fdf 100644 --- a/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CMakeAnalyzerTest.java +++ b/dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/CMakeAnalyzerTest.java @@ -52,6 +52,7 @@ public class CMakeAnalyzerTest extends BaseDBTestCase { * * @throws Exception if there is a problem */ + @Override @Before public void setUp() throws Exception { super.setUp(); diff --git a/dependency-check-core/src/test/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilterTest.java b/dependency-check-core/src/test/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilterTest.java index e03fbad9c..dca6675ab 100644 --- a/dependency-check-core/src/test/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilterTest.java +++ b/dependency-check-core/src/test/java/org/owasp/dependencycheck/data/lucene/TokenPairConcatenatingFilterTest.java @@ -47,11 +47,13 @@ public class TokenPairConcatenatingFilterTest extends BaseTokenStreamTestCase { public static void tearDownClass() { } + @Override @Before public void setUp() throws Exception { super.setUp(); } + @Override @After public void tearDown() throws Exception { super.tearDown(); diff --git a/dependency-check-core/src/test/java/org/owasp/dependencycheck/utils/FilterTest.java b/dependency-check-core/src/test/java/org/owasp/dependencycheck/utils/FilterTest.java index ac6d279ba..03a851590 100644 --- a/dependency-check-core/src/test/java/org/owasp/dependencycheck/utils/FilterTest.java +++ b/dependency-check-core/src/test/java/org/owasp/dependencycheck/utils/FilterTest.java @@ -64,6 +64,7 @@ public class FilterTest { } private static final Filter TEST_FILTER = new Filter() { + @Override public boolean passes(String str) { return str.contains("keep"); } diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/AggregateMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/AggregateMojo.java index d42d5f0e2..b6ca59a9a 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/AggregateMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/AggregateMojo.java @@ -263,6 +263,7 @@ public class AggregateMojo extends BaseDependencyCheckMojo { * @param locale the location * @return the report name */ + @Override public String getName(Locale locale) { return "dependency-check:aggregate"; } @@ -273,6 +274,7 @@ public class AggregateMojo extends BaseDependencyCheckMojo { * @param locale The Locale to get the description for * @return the description */ + @Override public String getDescription(Locale locale) { return "Generates an aggregate report of all child Maven projects providing details on any " + "published vulnerabilities within project dependencies. This report is a best " diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java index b07cadefe..1f67556cb 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java @@ -352,6 +352,7 @@ public abstract class BaseDependencyCheckMojo extends AbstractMojo implements Ma * @throws MavenReportException if a maven report exception occurs * @deprecated use {@link #generate(org.apache.maven.doxia.sink.Sink, java.util.Locale)} instead. */ + @Override @Deprecated public final void generate(@SuppressWarnings("deprecation") org.codehaus.doxia.sink.Sink sink, Locale locale) throws MavenReportException { generate((Sink) sink, locale); @@ -519,6 +520,7 @@ public abstract class BaseDependencyCheckMojo extends AbstractMojo implements Ma * * @return the output name */ + @Override public String getOutputName() { if ("HTML".equalsIgnoreCase(this.format) || "ALL".equalsIgnoreCase(this.format)) { return "dependency-check-report"; @@ -537,6 +539,7 @@ public abstract class BaseDependencyCheckMojo extends AbstractMojo implements Ma * * @return the category name */ + @Override public String getCategoryName() { return MavenReport.CATEGORY_PROJECT_REPORTS; } diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/CheckMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/CheckMojo.java index 17f2692d1..21b0b70f0 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/CheckMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/CheckMojo.java @@ -95,6 +95,7 @@ public class CheckMojo extends BaseDependencyCheckMojo { * @param locale the location * @return the report name */ + @Override public String getName(Locale locale) { return "dependency-check"; } @@ -105,6 +106,7 @@ public class CheckMojo extends BaseDependencyCheckMojo { * @param locale The Locale to get the description for * @return the description */ + @Override public String getDescription(Locale locale) { return "Generates a report providing details on any published vulnerabilities within project dependencies. " + "This report is a best effort and may contain false positives and false negatives."; diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/PurgeMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/PurgeMojo.java index 4d387d4bd..8551255e2 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/PurgeMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/PurgeMojo.java @@ -89,6 +89,7 @@ public class PurgeMojo extends BaseDependencyCheckMojo { * @param locale the location * @return the report name */ + @Override public String getName(Locale locale) { return "dependency-check-purge"; } @@ -99,6 +100,7 @@ public class PurgeMojo extends BaseDependencyCheckMojo { * @param locale The Locale to get the description for * @return the description */ + @Override public String getDescription(Locale locale) { return "Purges the local cache of the NVD dataT."; } diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/UpdateMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/UpdateMojo.java index dd5afdec6..0ad425613 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/UpdateMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/UpdateMojo.java @@ -78,6 +78,7 @@ public class UpdateMojo extends BaseDependencyCheckMojo { * @param locale the location * @return the report name */ + @Override public String getName(Locale locale) { return "dependency-check-update"; } @@ -88,6 +89,7 @@ public class UpdateMojo extends BaseDependencyCheckMojo { * @param locale The Locale to get the description for * @return the description */ + @Override public String getDescription(Locale locale) { return "Updates the local cache of the NVD data from NIST."; }