github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-03-20 08:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

codacy suggested change

Browse Source
This commit is contained in:
Jeremy Long
2017-11-13 06:42:18 -05:00
parent 16977e4869
commit 0536fa6c2a
3 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Evidence.java
View File

@@ -209,7 +209,7 @@ public class Evidence implements Serializable, Comparable<Evidence> {
@Override @Override
public int compareTo(Evidence o) { public int compareTo(Evidence o) {
if (o == null) { if (o == null) {
throw new NullPointerException("Unable to compare null evidence"); throw new IllegalArgumentException("Unable to compare null evidence");
} }
if (StringUtils.equalsIgnoreCase(source, o.source)) { if (StringUtils.equalsIgnoreCase(source, o.source)) {
if (StringUtils.equalsIgnoreCase(name, o.name)) { if (StringUtils.equalsIgnoreCase(name, o.name)) {

2
dependency-check-core/src/main/java/org/owasp/dependencycheck/dependency/Identifier.java
View File

@@ -262,7 +262,7 @@ public class Identifier implements Serializable, Comparable<Identifier> {
@Override @Override
public int compareTo(Identifier o) { public int compareTo(Identifier o) {
if (o == null) { if (o == null) {
throw new NullPointerException("Unable to compare a null identifier"); throw new IllegalArgumentException("Unable to compare a null identifier");
} }
return new CompareToBuilder() return new CompareToBuilder()
.append(this.type, o.type) .append(this.type, o.type)

1
dependency-check-core/src/test/java/org/owasp/dependencycheck/analyzer/RubyBundleAuditAnalyzerIT.java
View File

@@ -22,7 +22,6 @@ import edu.emory.mathcs.backport.java.util.Arrays;
import java.io.File; import java.io.File;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.SortedSet;
import org.junit.After; import org.junit.After;
import org.junit.Assume; import org.junit.Assume;