diff --git a/dependency-check-ant/src/main/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTask.java b/dependency-check-ant/src/main/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTask.java index 106c098e8..04169803f 100644 --- a/dependency-check-ant/src/main/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTask.java +++ b/dependency-check-ant/src/main/java/org/owasp/dependencycheck/taskdefs/DependencyCheckTask.java @@ -968,7 +968,7 @@ public class DependencyCheckTask extends Task { Settings.setBoolean(Settings.KEYS.AUTO_UPDATE, autoUpdate); if (proxyUrl != null && !proxyUrl.isEmpty()) { - Settings.setString(Settings.KEYS.PROXY_URL, proxyUrl); + Settings.setString(Settings.KEYS.PROXY_SERVER, proxyUrl); } if (proxyPort != null && !proxyPort.isEmpty()) { Settings.setString(Settings.KEYS.PROXY_PORT, proxyPort); diff --git a/dependency-check-cli/src/main/java/org/owasp/dependencycheck/App.java b/dependency-check-cli/src/main/java/org/owasp/dependencycheck/App.java index 15b2df2b2..74ad6d9b6 100644 --- a/dependency-check-cli/src/main/java/org/owasp/dependencycheck/App.java +++ b/dependency-check-cli/src/main/java/org/owasp/dependencycheck/App.java @@ -213,7 +213,7 @@ public class App { } Settings.setBoolean(Settings.KEYS.AUTO_UPDATE, autoUpdate); if (proxyUrl != null && !proxyUrl.isEmpty()) { - Settings.setString(Settings.KEYS.PROXY_URL, proxyUrl); + Settings.setString(Settings.KEYS.PROXY_SERVER, proxyUrl); } if (proxyPort != null && !proxyPort.isEmpty()) { Settings.setString(Settings.KEYS.PROXY_PORT, proxyPort); diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java index 56cefcdcf..c49779843 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/agent/DependencyCheckScanAgent.java @@ -809,7 +809,7 @@ public class DependencyCheckScanAgent { Settings.setBoolean(Settings.KEYS.AUTO_UPDATE, autoUpdate); if (proxyUrl != null && !proxyUrl.isEmpty()) { - Settings.setString(Settings.KEYS.PROXY_URL, proxyUrl); + Settings.setString(Settings.KEYS.PROXY_SERVER, proxyUrl); } if (proxyPort != null && !proxyPort.isEmpty()) { Settings.setString(Settings.KEYS.PROXY_PORT, proxyPort); diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nexus/NexusSearch.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nexus/NexusSearch.java index 306f540a2..ec406a916 100644 --- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nexus/NexusSearch.java +++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/data/nexus/NexusSearch.java @@ -64,7 +64,7 @@ public class NexusSearch { public NexusSearch(URL rootURL) { this.rootURL = rootURL; try { - if (null != Settings.getString(Settings.KEYS.PROXY_URL) + if (null != Settings.getString(Settings.KEYS.PROXY_SERVER) && Settings.getBoolean(Settings.KEYS.ANALYZER_NEXUS_PROXY)) { useProxy = true; LOGGER.fine("Using proxy"); diff --git a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/DependencyCheckMojo.java b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/DependencyCheckMojo.java index 88335665e..ab5e6a4ca 100644 --- a/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/DependencyCheckMojo.java +++ b/dependency-check-maven/src/main/java/org/owasp/dependencycheck/maven/DependencyCheckMojo.java @@ -838,7 +838,7 @@ public class DependencyCheckMojo extends AbstractMojo implements MavenMultiPageR final Proxy proxy = getMavenProxy(); if (proxy != null) { - Settings.setString(Settings.KEYS.PROXY_URL, getMavenSettingsProxyUrl(proxy)); + Settings.setString(Settings.KEYS.PROXY_SERVER, getMavenSettingsProxyUrl(proxy)); Settings.setString(Settings.KEYS.PROXY_PORT, Integer.toString(proxy.getPort())); final String userName = proxy.getUsername(); final String password = proxy.getPassword(); @@ -849,7 +849,7 @@ public class DependencyCheckMojo extends AbstractMojo implements MavenMultiPageR } if (proxyUrl != null && !proxyUrl.isEmpty()) { - Settings.setString(Settings.KEYS.PROXY_URL, proxyUrl); + Settings.setString(Settings.KEYS.PROXY_SERVER, proxyUrl); } if (proxyPort != null && !proxyPort.isEmpty()) { Settings.setString(Settings.KEYS.PROXY_PORT, proxyPort); diff --git a/dependency-check-utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java b/dependency-check-utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java index 4176ec720..5ae1b94ef 100644 --- a/dependency-check-utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java +++ b/dependency-check-utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java @@ -51,7 +51,7 @@ public final class URLConnectionFactory { public static HttpURLConnection createHttpURLConnection(URL url) throws URLConnectionFailureException { HttpURLConnection conn = null; Proxy proxy = null; - final String proxyUrl = Settings.getString(Settings.KEYS.PROXY_URL); + final String proxyUrl = Settings.getString(Settings.KEYS.PROXY_SERVER); try { if (proxyUrl != null) { final int proxyPort = Settings.getInt(Settings.KEYS.PROXY_PORT); diff --git a/dependency-check-utils/src/test/java/org/owasp/dependencycheck/utils/DownloaderIntegrationTest.java b/dependency-check-utils/src/test/java/org/owasp/dependencycheck/utils/DownloaderIntegrationTest.java index 7feeaeb6a..530a8faae 100644 --- a/dependency-check-utils/src/test/java/org/owasp/dependencycheck/utils/DownloaderIntegrationTest.java +++ b/dependency-check-utils/src/test/java/org/owasp/dependencycheck/utils/DownloaderIntegrationTest.java @@ -38,7 +38,7 @@ public class DownloaderIntegrationTest extends BaseTest { // Settings.setString(Settings.KEYS.CONNECTION_TIMEOUT, "1000"); // Settings.setString(Settings.KEYS.PROXY_PORT, "8080"); -// Settings.setString(Settings.KEYS.PROXY_URL, "127.0.0.1"); +// Settings.setString(Settings.KEYS.PROXY_SERVER, "127.0.0.1"); URL url = new URL(Settings.getString(Settings.KEYS.CVE_MODIFIED_20_URL)); File outputPath = new File("target/downloaded_cve.xml"); Downloader.fetchFile(url, outputPath);