github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-03-28 11:52:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Removed a redundant null check, and replaced an addAll with the constructor population.

Browse Source
This commit is contained in:
Anthony Whitford
2015-09-07 14:51:26 -07:00
parent af0255ee09
commit 01450bacc2
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/ArchiveAnalyzer.java
View File

@@ -184,7 +184,7 @@ public class ArchiveAnalyzer extends AbstractFileTypeAnalyzer {
if (tempFileLocation != null && tempFileLocation.exists()) { if (tempFileLocation != null && tempFileLocation.exists()) {
LOGGER.debug("Attempting to delete temporary files"); LOGGER.debug("Attempting to delete temporary files");
final boolean success = FileUtils.delete(tempFileLocation); final boolean success = FileUtils.delete(tempFileLocation);
if (!success && tempFileLocation != null && tempFileLocation.exists() && tempFileLocation.list().length > 0) { if (!success && tempFileLocation.exists() && tempFileLocation.list().length > 0) {
LOGGER.warn("Failed to delete some temporary files, see the log for more details"); LOGGER.warn("Failed to delete some temporary files, see the log for more details");
} }
} }
@@ -278,8 +278,7 @@ public class ArchiveAnalyzer extends AbstractFileTypeAnalyzer {
final Set<Dependency> newDependencies; final Set<Dependency> newDependencies;
if (sizeChanged) { if (sizeChanged) {
//get the new dependencies //get the new dependencies
newDependencies = new HashSet<Dependency>(); newDependencies = new HashSet<Dependency>(after);
newDependencies.addAll(after);
newDependencies.removeAll(before); newDependencies.removeAll(before);
} else { } else {
newDependencies = EMPTY_DEPENDENCY_SET; newDependencies = EMPTY_DEPENDENCY_SET;