Adam Melkus adam
  • Joined on 2025-12-28
adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:28 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@pwinnski commented on GitHub (Feb 15, 2026):

Sure, I understand. I did test with my mobile client and deliberately disabled wifi to cause a gap, but only by some minutes, not days. But of…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:28 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@Vito0912 commented on GitHub (Feb 15, 2026):

Sorry, to answer again. I think we are talking past each other, and I know I explain things very badly. That is why I do not answer issues much…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:28 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@pwinnski commented on GitHub (Feb 15, 2026):

NOW I understand! What you are missing is that date is not the actual date the session started, but the date the session ended. This is…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:28 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@Vito0912 commented on GitHub (Feb 15, 2026):

I don't really understand why you closed the PR. Again, I have nothing to say about it getting merged or not.

The link you shared is for syncing…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:28 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@Vito0912 commented on GitHub (Feb 15, 2026):

I updated my comment in that regard. With this in mind it actually makes sense to some degree. I understood it the way that it counted the day…

adam opened issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight
adam closed issue starred/audiobookshelf#3236 2026-04-25 00:14:27 +02:00
[Bug]: IDOR in Media Progress Controller
adam closed issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight
adam commented on issue starred/audiobookshelf#3236 2026-04-25 00:14:27 +02:00
[Bug]: IDOR in Media Progress Controller

@mandreko commented on GitHub (Feb 16, 2026):

I'm not entirely sure yet, but this may also affect the createBookmark and getItemListeningSessions methods as well, since I don't see access…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@Vito0912 commented on GitHub (Feb 14, 2026):

Duplicate of https://github.com/advplyr/audiobookshelf/issues/1445

TL;DR ABS has no way of tracking this atm and it is impossible to retroactively…

adam commented on issue starred/audiobookshelf#3236 2026-04-25 00:14:27 +02:00
[Bug]: IDOR in Media Progress Controller

@github-actions[bot] commented on GitHub (Mar 12, 2026):

Fixed in v2.33.0.

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@pwinnski commented on GitHub (Feb 14, 2026):

Oops, I searched two different terms, but missed that one, sorry.

I don't think it's a question of retroactively modifying stored data, nor of…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@Vito0912 commented on GitHub (Feb 14, 2026):

it seems like modifying getUserListeningStatsHelpers() to return different results when s.createdAt and s.updatedAt are on different days might…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@pwinnski commented on GitHub (Feb 15, 2026):

One of us is not understanding the other, or perhaps both. I'm definitely not suggesting shifting everything to another day! Very few sessions cross…

adam commented on issue starred/audiobookshelf#3237 2026-04-25 00:14:27 +02:00
[Bug]: Days in a Row doesn't count sessions started before midnight

@Vito0912 commented on GitHub (Feb 15, 2026):

No, I understand that. But the PR ignores that updatedAt has absolutely nothing to do with the timeListened. The relation can only be connected in a…

adam commented on issue starred/audiobookshelf#3233 2026-04-25 00:14:26 +02:00
[Bug]: API progress crashes server if episodeId is missing

@LMSSonos commented on GitHub (Feb 14, 2026):

it's a podcast library

adam commented on issue starred/audiobookshelf#3232 2026-04-25 00:14:26 +02:00
[Enhancement]: Video playback

@Dasnap commented on GitHub (Feb 20, 2026):

I know for me personally, I've been looking for a good open-source alternative for Pocket Casts, as I assume it's a 'when' and not an 'if' for its…

adam commented on issue starred/audiobookshelf#3233 2026-04-25 00:14:26 +02:00
[Bug]: API progress crashes server if episodeId is missing

@github-actions[bot] commented on GitHub (Mar 12, 2026):

Fixed in v2.33.0.

adam opened issue starred/audiobookshelf#3235 2026-04-25 00:14:26 +02:00
[Enhancement]: Better series display for covers with black borders
adam opened issue starred/audiobookshelf#3236 2026-04-25 00:14:26 +02:00
[Bug]: IDOR in Media Progress Controller